Re: [9fans] broken contrib source

[Noah Evans <noah.evans@gmail.com>]

Aaaah..... now I get it. I found it in fgb's tree. Has any announcing
config(1) on the list?

On Thu, Aug 20, 2009 at 12:20 AM, Noah Evans<noah.evans@gmail.com> wrote:
> Which machine is this on? I don't quite understand what you're saying.
> Aren't the contrib packages you're talking about something outside the
> main distribution?
>
> On Thu, Aug 20, 2009 at 12:02 AM, John Floren<slawmaster@gmail.com> wrote:
>> Upon trying to build /sys/src/cmd for the arm today (beagleboards came
>> in), I found that mk was dying due to bad source installed by
>> contrib(1) packages. mk -k install was able to get me through most of
>> it, but the three worst offenders didn't even have mkfiles in their
>> top levels; since I didn't really care about having them, I deleted
>> the directories and continued. Those three offenders:
>> 1. "contrib", which seems to have only one file in it.
>> 2. "tcl"
>> 3. "vim"
>>
>> And, while it didn't bring mk -k to a grinding halt, I did notice
>> that, with nupas installed,  "cd /sys/src/cmd/upas; objtype=arm mk
>> install" chokes on /sys/src/cmd/upas/imap4.c/imap4.c.
>>
>> Please, those of you who make contrib packages, don't dump source into
>> /sys/src without first checking that it can actually build! It's not
>> too difficult to do a "mk install" in /sys/src/cmd after you put the
>> source in there. Maybe there should be a contrib/verify script which
>> goes through /sys/src and makes sure everything can still build
>> normally?
>>
>>
>>
>> John
>> --
>> "Object-oriented design is the roman numerals of computing" -- Rob Pike
>>
>>
>