From: Skip Tavakkolian <9nut@9netics.com>
To: 9fans@9fans.net
Subject: Re: [9fans] How to submit a patch for 9fans.net/go/plan9/client?
Date: Tue, 8 Sep 2015 20:29:03 -0700 [thread overview]
Message-ID: <573d3d98030b70845269c36ccf8b083b@9netics.com> (raw)
In-Reply-To: <CAFqAhKriF4VBUrv+ZVpRU01-BEbvwLaxdSbfA6akOwqn9L-gtg@mail.gmail.com>
i would guess that at least rsc and rob review pull requests; a pull
request would be the best bet.
> Hi,
>
> I'd like to fix the XXX at
> https://github.com/9fans/go/blob/master/plan9/client/conn.go#L41-L46. Per
> the man page, version should send a tag of NOTAG, and it currently sends a
> 1. Making it so, and then replacing the rpc() call with c.write followed
> by a c.read should do the trick.
>
> How do I submit a patch? I see forks on github, but no one merging back to
> 9fans. Is there a codereview link somewhere I should use? Or just a
> normal github pull request.
>
> Thanks,
>
> Mark
next prev parent reply other threads:[~2015-09-09 3:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 1:54 Mark Bucciarelli
2015-09-09 3:29 ` Skip Tavakkolian [this message]
2015-09-09 4:27 ` lucio
2015-09-09 7:52 ` Jeremy Jackins
2015-09-09 9:43 ` lucio
2015-09-09 9:59 ` Aram Hăvărneanu
2015-09-09 23:48 ` Mark Bucciarelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573d3d98030b70845269c36ccf8b083b@9netics.com \
--to=9nut@9netics.com \
--cc=9fans@9fans.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).