From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <592643f7ffafc790c9482d76f00a4b23@plan9.bell-labs.com> From: David Presotto To: mirtchov@cpsc.ucalgary.ca, 9fans@cse.psu.edu Subject: Re: [9fans] proposal: a patch acceptance system MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="upas-xfefuvgnmlghlfpgmdhlvsdkbe" Date: Sun, 2 Nov 2003 12:32:46 -0500 Topicbox-Message-UUID: 7c04d73c-eacc-11e9-9e20-41e7f4b1d025 This is a multi-part message in MIME format. --upas-xfefuvgnmlghlfpgmdhlvsdkbe Content-Disposition: inline Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit I'm of mixed minds. If you send something to 9trouble, I will respond fairly quickly modulo not being around for a week every now and then. If you send something to 9fans, I could take a while because I tend to miss things when a flame war is going on. I would suggest that contributions at least get sent to 9trouble and, if you want wider immediate distribution, to 9fans. I'm also not averse to leaving a patch area on sources that people can indescriminately dump into. I don't understand how to avoid abuse problems, but I would draft a 9grid like policy (i.e. don't be stupid) and leave it in an obvious place. However, I don't want to turn this into Linux where you need something like debian to find a set of patches (or CVS's) that actually make sense together. --upas-xfefuvgnmlghlfpgmdhlvsdkbe Content-Type: message/rfc822 Content-Disposition: inline Received: from plan9.cs.bell-labs.com ([135.104.9.2]) by plan9; Sun Nov 2 12:03:32 EST 2003 Received: from mail.cse.psu.edu ([130.203.4.6]) by plan9; Sun Nov 2 12:03:29 EST 2003 Received: by mail.cse.psu.edu (CSE Mail Server, from userid 60001) id CD60B19BA0; Sun, 2 Nov 2003 12:03:20 -0500 (EST) Received: from psuvax1.cse.psu.edu (psuvax1.cse.psu.edu [130.203.23.6]) by mail.cse.psu.edu (CSE Mail Server) with ESMTP id E48B219B9D; Sun, 2 Nov 2003 12:03:06 -0500 (EST) X-Original-To: 9fans@cse.psu.edu Delivered-To: 9fans@cse.psu.edu Received: by mail.cse.psu.edu (CSE Mail Server, from userid 60001) id B26A019B7F; Sun, 2 Nov 2003 12:02:12 -0500 (EST) Received: from fbsd.cpsc.ucalgary.ca (fbsd.cpsc.ucalgary.ca [136.159.7.68]) by mail.cse.psu.edu (CSE Mail Server) with ESMTP id B5ED319A71 for <9fans@cse.psu.edu>; Sun, 2 Nov 2003 12:02:00 -0500 (EST) Received: from fbsd.cpsc.ucalgary.ca (localhost.localdomain [127.0.0.1]) by fbsd.cpsc.ucalgary.ca (8.12.8/8.12.8) with ESMTP id hA2H1snK021631 for <9fans@cse.psu.edu>; Sun, 2 Nov 2003 10:01:54 -0700 Received: from localhost (mirtchov@localhost) by fbsd.cpsc.ucalgary.ca (8.12.8/8.12.8/Submit) with ESMTP id hA2H1sSU021627 for <9fans@cse.psu.edu>; Sun, 2 Nov 2003 10:01:54 -0700 X-Authentication-Warning: fbsd.cpsc.ucalgary.ca: mirtchov owned process doing -bs From: andrey mirtchovski To: 9fans@cse.psu.edu Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: [9fans] proposal: a patch acceptance system Sender: 9fans-admin@cse.psu.edu Errors-To: 9fans-admin@cse.psu.edu X-BeenThere: 9fans@cse.psu.edu X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: 9fans@cse.psu.edu List-Id: Fans of the OS Plan 9 from Bell Labs <9fans.cse.psu.edu> List-Archive: Date: Sun, 2 Nov 2003 10:01:54 -0700 (MST) X-Spam-Status: No, hits=-0.4 required=5.0 tests=USER_AGENT_PINE,X_AUTH_WARNING version=2.55 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) Hello, Several people have discussed on IRC the need for a definitive way of submitting patches (enhancements and fixes) to Plan 9 developers with write privileges. Currently this happens in three different ways -- sending patches to 9fans, sending patches (fixes mostly) to 9trouble, and via personal communication with people who can do a push on sources. What this mechanism lacks is an easy way to get feedback on rejected or accepted patches, and a way for developers to discriminate good and bad ones and to know which patches have been outstanding. We think the following solution could be sufficiently simple and general to accomodate our needs: Enhancements and fixes by people lacking the ability to 'push' on sources could be put (by the users themselves) in a world-writeable directory "/patches" on sources.cs.bell-labs.com. A particular set of patched files submitted by a user will be located in: /patches/MMDD.user/* where MM is the month, DD is the day and 'user' is the username of the person submitting the patch, as it appears on the sources auth server. Along with the changed files the user must submit a short README describing in detail what this patch accomplishes, and where those files appear relevant to the root of a Plan 9 system tree (no need to create complex directory structures just to put a couple of files there). Whether an announcement is made to 9fans or not is left for the user to decide. Plan 9 developers can then examine /patch for outstanding patches and either add them to the system, in which case the MMDD.user directory can disappear (it will be available in the next pull) or reject them, in which case they go to: /patches/rejected/MMDD.user/ with a small 'reason' file added, where the reason for the rejection is given. This could be made private and viewable only by the person who submitted the patch. One major issue with this scheme is synchronization -- making sure the files submitted patch the latest system is left as an exercise for the patch submitter, and making sure there's no "push"-ing of files for which there are patches outstanding is done by the person doing the "push" (it's just a simple "ls /patches/*/file" before "push -c /path/to/file" is done on sources)... Any coments will be appreciated, as long as you have in mind that we're trying to cut short of writing a new bugzilla :) andrey --upas-xfefuvgnmlghlfpgmdhlvsdkbe--