From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <5d375e920712210840j3a76a0c9o4e8b2d940be7e831@mail.gmail.com> Date: Fri, 21 Dec 2007 11:40:00 -0500 From: Uriel To: "Fans of the OS Plan 9 from Bell Labs" <9fans@cse.psu.edu> Subject: Re: [9fans] Abaco: url parsing problem In-Reply-To: <476BE618.5040403@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <5d375e920712210739j27248993o683fa145a0bdcc8@mail.gmail.com> <476BE618.5040403@gmx.de> Topicbox-Message-UUID: 1fb1d46a-ead3-11e9-9d60-3106f5b1d025 On Dec 21, 2007 11:13 AM, Kernel Panic wrote: > Uriel wrote: > > >That is why somebody (cough) riped out the url parsing code from webfs > >and put it into a library, and then updated abaco to use that > >library... but we all know here code and effort duplication is good, > >so never mind. > > > > > the browser needs to understand url-encoding anyway beacause he > he needs to touch the url (build absolute urls from relatives in context > of the fetched > page). so having the lib in abaco is ok i think. Lets not forget javascript and other such abominations. And that is *precisely* why having two half broken sets of URL parsing/manipulation code, one in webfs and one in abaco is so silly. And why I factored out the url code in webfs and put it into a liburl, and then modified abaco link against that instead of its own simplistic and broken URL code. The result has been on my sources/contrib dir for ages, why fgb has not used it is beyond me. uriel > but maybe other stuff could gain from webfs *fixing* urls. maybe some > rc-scripts where you > dont want to urlencode stuff first? for example you want to fetch a > search-result page > and dont want to urlencode your concatenated search query before passing > it to webfs? > > makes that sense? ;-) > > > >uriel > > > >On Dec 20, 2007 4:27 PM, Federico G. Benavento wrote: > > > > > >>>Does webfs do the url parsing? or abaco before sending it to webfs, if so, maybe > >>>the function can be fixed easily. > >>> > >>> > >>I guess, my urlencode is broken, I'll fix it later > >> > >>thanks > >> > >>Federico G. Benavento > >> > >>--- > >>/bin/fortune: > >> > >> > >>Even the simplest solution is bound to have something wrong with it. > >> > >> > -- > cinap > >