Re: [9fans] sed crash

[Uriel <uriel99@gmail.com>]

That was even faster than I expected. Thanks Russ!

uriel

P.S.: Silly question, why is du(1) not built by default in p9p? The
code already there seems to work as far as I can tell..

On Thu, Feb 5, 2009 at 5:15 AM, Russ Cox <rsc@swtch.com> wrote:
> Sed is fixed in plan9port.
>
> $ hg diff sed.c
> diff -r 478b53880a80 src/cmd/sed.c
> --- a/src/cmd/sed.c     Wed Feb 04 20:12:48 2009 -0800
> +++ b/src/cmd/sed.c     Wed Feb 04 20:13:08 2009 -0800
> @@ -994,7 +994,7 @@
>                return 0;
>        subexp[0].s.rsp = buf;
>        subexp[0].e.rep = 0;
> -       if (rregexec(pattern, linebuf, subexp, MAXSUB)) {
> +       if (rregexec(pattern, linebuf, subexp, MAXSUB) > 0) {
>                loc1 = subexp[0].s.rsp;
>                loc2 = subexp[0].e.rep;
>                return 1;
> $
>
> http://hg.pdos.csail.mit.edu/hg/plan9/rev/0bf86c524c9b
>
>