9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: arisawa <arisawa@ar.aichi-u.ac.jp>
To: Fans of the OS Plan 9 from Bell Labs <9fans@9fans.net>
Subject: [9fans] segattach in telnetd
Date: Sun, 14 Sep 2014 11:54:30 +0900	[thread overview]
Message-ID: <63E9BCDE-8F08-40AF-89C4-E50FF60F2BDF@ar.aichi-u.ac.jp> (raw)

Hello,

we have an example for segattach() in /sys/src/cmd/ip/telnetd.c

void*
share(ulong len)
{
	uchar *vastart;

	vastart = sbrk(0);
	if(vastart == (void*)-1)
		return 0;
	vastart += 2*1024*1024;

	if(segattach(0, "shared", vastart, len) == (void*)-1)
		return 0;

	return vastart;
}

I think it should be
-	if(segattach(0, "shared", vastart, len) == (void*)-1)
+	if((vastart = segattach(0, "shared", vastart, len)) == (void*)-1)

Kenji Arisawa




             reply	other threads:[~2014-09-14  2:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-14  2:54 arisawa [this message]
2014-09-14  3:17 ` cinap_lenrek
2014-09-14  3:49   ` arisawa
2014-09-14  4:23     ` cinap_lenrek
2014-09-14  4:41   ` arisawa
2014-09-14  4:51     ` cinap_lenrek
2014-09-14  5:33       ` arisawa
2014-09-14  5:55         ` cinap_lenrek
2014-09-14 14:43         ` erik quanstrom
2014-09-14 19:04           ` Charles Forsyth
2014-09-15 16:59           ` erik quanstrom
2014-09-14  5:04     ` cinap_lenrek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63E9BCDE-8F08-40AF-89C4-E50FF60F2BDF@ar.aichi-u.ac.jp \
    --to=arisawa@ar.aichi-u.ac.jp \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).