9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: erik quanstrom <quanstro@quanstro.net>
To: 9fans@9fans.net
Subject: Re: [9fans] 9vx
Date: Tue,  1 Jul 2008 09:25:12 -0400	[thread overview]
Message-ID: <66b9839fdb955f8f969063ccff722c4c@quanstro.net> (raw)
In-Reply-To: <20080701120805.22ECF1E8C22@holo.morphisms.net>

>> Here's the fix for the fdisk problem:
>>
>> /sys/src/cmd/disk/prep/edit.c:503,508 - edit.c:503,509
>>   	 */
>>   	for(i=0; i<edit->nctlpart; i++) {
>>   		p = edit->ctlpart[i];
>> + 		if(strncmp(p->ctlname, "data", 5) != 0)
>>   		if(p->changed)
>>   		if(fprint(ctlfd, "delpart %s\n", p->ctlname)<0) {
>>   			fprint(2, "delpart failed: %s: %r\n", p->ctlname);

on second read, with this approach, i would think that strcmp() not
strncmp should be used.

>
> That would work, but one wonders why
> the normal kernel doesn't have this problem.

this must be a quirk of the interaction between
devsd and fdisk.  by hand data does disappear:

	; lc
	9fat	ctl	data	nvram	plan9	raw
	; for(i in 9fat data nvram plan9 data)echo delpart $i>ctl
	; lc
	ctl	raw

by the way, be very careful with this before
applying this patch:

; diff -c /sys/src/9/port/devsd.c /n/dump/2008/0701/sys/src/9/port/devsd.c
/sys/src/9/port/devsd.c:147,153 - /n/dump/2008/0701/sys/src/9/port/devsd.c:147,152
  	 */
  	pp = unit->part;
  	for(i = 0; i < unit->npart; i++){
- 		if(pp->name)
  		if(strcmp(name, pp->name) == 0)
  			break;
  		pp++;

this is required because npart is set to the number
of partitions allocated.  the names never-set partitions
might be 0.  otherwise "delpart missingpart>/dev/sdXX/ctl"
will be a noisy and somewhat gratituous synonym for
"echo reboot>/dev/reboot".

- erik




  reply	other threads:[~2008-07-01 13:25 UTC|newest]

Thread overview: 91+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-27 11:07 9vx Russ Cox
2008-06-27 13:18 ` [9fans] 9vx David Leimbach
2008-06-27 13:40   ` David Leimbach
2008-06-27 13:46     ` Pietro Gagliardi
2008-06-27 13:50       ` Russ Cox
2008-06-27 13:58         ` a
2008-06-27 13:56       ` David Leimbach
2008-06-27 13:49     ` a
2008-06-27 13:59       ` Russ Cox
2008-06-27 13:49     ` Latchesar Ionkov
2008-06-27 13:57       ` David Leimbach
2008-06-27 13:52     ` Russ Cox
2008-06-27 13:58       ` David Leimbach
2008-06-27 13:58       ` Venkatesh Srinivas
2008-06-27 14:08         ` john
2008-06-27 14:12           ` erik quanstrom
2008-06-30 15:32             ` sqweek
2008-06-30 16:09               ` Russ Cox
2008-06-30 17:00                 ` andrey mirtchovski
2008-06-30 17:07                   ` andrey mirtchovski
2008-06-30 18:02                   ` Russ Cox
2008-06-30 18:34                     ` andrey mirtchovski
2008-06-30 18:44                       ` Russ Cox
2008-06-27 14:19           ` Russ Cox
2008-06-27 14:10         ` Gorka Guardiola
2008-06-27 14:11           ` erik quanstrom
2008-06-27 14:21       ` David Leimbach
2008-06-27 14:29         ` Russ Cox
2008-06-27 14:30         ` Pat Hacker
2008-06-27 14:32           ` Francisco J Ballesteros
2008-06-27 14:34             ` David Leimbach
2008-06-27 14:39             ` andrey mirtchovski
2008-06-27 14:45               ` David Leimbach
2008-06-27 14:47                 ` David Leimbach
2008-06-27 14:55               ` andrey mirtchovski
2008-06-27 15:31             ` andrey mirtchovski
2008-06-27 14:57 ` ron minnich
2008-06-27 15:14   ` ron minnich
2008-06-27 15:17   ` Russ Cox
2008-06-27 15:52     ` ron minnich
2008-06-27 17:39       ` ron minnich
2008-06-27 18:57         ` Pietro Gagliardi
2008-06-27 18:59         ` David Leimbach
2008-06-27 21:39           ` ron minnich
2008-06-27 22:51             ` David Leimbach
2008-06-27 23:29             ` Brian L. Stuart
2008-06-28  0:36               ` ron minnich
2008-06-28  4:59               ` Brian L. Stuart
2008-06-28 11:25                 ` erik quanstrom
2009-04-28  5:10     ` ron minnich
2009-04-30 14:12       ` Russ Cox
2008-06-27 15:41   ` Uriel
2008-06-27 15:54     ` ron minnich
2008-06-27 23:13 ` Skip Tavakkolian
2008-06-27 23:24   ` Skip Tavakkolian
2008-06-27 23:34   ` Pietro Gagliardi
2008-06-27 23:52     ` David Leimbach
2008-06-28  5:03   ` lucio
2008-06-28 15:23     ` Russ Cox
2008-06-28 17:29       ` lucio
2008-06-28 17:30       ` Pietro Gagliardi
2008-07-01  2:29       ` Anthony Martin
2008-07-01  9:09         ` erik quanstrom
2008-07-01 12:10         ` Russ Cox
2008-07-01 13:25           ` erik quanstrom [this message]
2008-07-01 14:40             ` Russ Cox
2008-07-01 17:23               ` erik quanstrom
2008-07-01 17:32                 ` Russ Cox
2008-07-01 18:50                   ` erik quanstrom
2008-07-01 19:11                     ` rc bug Russ Cox
2008-07-01 21:13                       ` [9fans] " erik quanstrom
2008-07-01 21:28                         ` [9fans] 9vx ps bug Russ Cox
2008-07-01 21:59                       ` [9fans] rc bug Fazlul Shahriar
2008-07-01 23:11                         ` Russ Cox
2008-07-01 23:12                           ` erik quanstrom
2008-07-01 23:31                             ` Russ Cox
2008-07-01 23:38                               ` erik quanstrom
2008-06-28 17:28     ` [9fans] 9vx Pietro Gagliardi
2008-06-28 17:35       ` Pietro Gagliardi
2008-06-27 23:41 ` Dave Eckhardt
2008-06-27 23:52   ` David Leimbach
2008-06-28  0:23   ` Uriel
2008-06-28 15:32     ` David Leimbach
2008-06-28  4:36 ` Fernan Bolando
2008-12-21 19:19 erik quanstrom
2008-12-22 18:52 ` Russ Cox
2023-06-25  5:53 Ben Huntsman
2023-06-25 18:59 ` David du Colombier
2023-06-26  9:28 ` Stuart Morrow
2023-06-26 13:39   ` hiro
2023-06-26 17:49     ` ibrahim via 9fans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66b9839fdb955f8f969063ccff722c4c@quanstro.net \
    --to=quanstro@quanstro.net \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).