From: erik quanstrom <quanstro@quanstro.net>
To: 9fans@9fans.net
Subject: Re: [9fans] ainc() 386/amd64 differences
Date: Wed, 14 May 2014 17:26:36 -0400 [thread overview]
Message-ID: <69df9a1401f0f33ca80a73b221d7758d@ladd.quanstro.net> (raw)
In-Reply-To: <CAOw7k5jUAoMvn1eXYB2iC2EBn_tEHLdGpnuQ5EDc=OAZaGCcFg@mail.gmail.com>
> int
> incref(Ref *r)
> {
> int x;
>
> x = ainc(&r->ref);
> if(x <= 0)
> panic("incref pc=%#p", getcallerpc(&r));
> return x;
> }
ah, yes. i'd not remembered this nice implementation.
then your ainc is guard-free? and your Ref is struct Ref {int ref;}?
also, did you decide that any reuse of the ref lock is already buggy and needs
no further review? that's the bit i got bogged down on.
- erik
next prev parent reply other threads:[~2014-05-14 21:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 20:34 erik quanstrom
2014-05-14 20:57 ` Charles Forsyth
2014-05-14 21:26 ` erik quanstrom [this message]
2014-05-14 21:46 ` erik quanstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69df9a1401f0f33ca80a73b221d7758d@ladd.quanstro.net \
--to=quanstro@quanstro.net \
--cc=9fans@9fans.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).