From: cinap_lenrek@felloff.net
To: 9fans@9fans.net
Subject: [9fans] devproc procctl close bug
Date: Mon, 26 May 2014 22:09:04 +0200 [thread overview]
Message-ID: <6d31ccaeeb641db8911b837f7905949a@felloff.net> (raw)
theres a bug in devproc again.
the fd is not bounds checked for the "close fd"
procctl command and the "closefiles" command misses
the last fd as it iterates from:
fd=0 to maxfd-1 and not to maxfd in procctlclosefiles()
static void
procctlcloseone(Proc *p, Fgrp *f, int fd)
{
Chan *c;
c = f->fd[fd]; // <-- not checked
if(c == nil)
return;
f->fd[fd] = nil;
unlock(f);
qunlock(&p->debug);
cclose(c);
qlock(&p->debug);
lock(f);
}
procctlclosefiles(Proc *p, int all, int fd)
{
int i;
Fgrp *f;
f = p->fgrp;
if(f == nil)
error(Eprocdied);
lock(f);
f->ref++;
if(all)
for(i = 0; i < f->maxfd; i++) // <-- wrong
procctlcloseone(p, f, i);
else
procctlcloseone(p, f, fd);
unlock(f);
closefgrp(f);
}
...
case CMclose:
procctlclosefiles(p, 0, atoi(cb->f[1])); // <-- fd can be anything
break;
case CMclosefiles:
procctlclosefiles(p, 1, 0);
break;
--
cinap
next reply other threads:[~2014-05-26 20:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 20:09 cinap_lenrek [this message]
2014-05-26 20:27 ` erik quanstrom
2014-05-26 20:31 ` cinap_lenrek
2014-05-26 20:33 ` erik quanstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d31ccaeeb641db8911b837f7905949a@felloff.net \
--to=cinap_lenrek@felloff.net \
--cc=9fans@9fans.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).