9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: Saroj Mahapatra <saroj@optonline.net>
To: 9fans@cse.psu.edu
Subject: [9fans] bug in fmtfmt
Date: Mon, 15 Jul 2002 09:31:24 +0000	[thread overview]
Message-ID: <6d3220b4.0207121744.4fc802e6@posting.google.com> (raw)

There is a bug in fmtfmt.

for (p=knownfmt; p->c; p++)
   if (p->c == c) {
      fmtinstanll(p->c, p->fmt);
      while (p->fmt == nil)  <--------- BUG
          ;
      
The pointer 'p' is walking through 'knownfmt'; so p->fmt can not be
nil there, becuase 'fmtinstall' only changes 'fmtalloc' array. There
is also locking issue between 'fmtinstall' and 'fmtfmt' accessing
'fmtalloc' array simultaneously.

Please take a look at this. I wish I had more time to explain this
thoroughly at this moment.

Thanks,
Saroj Mahapatra


             reply	other threads:[~2002-07-15  9:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-15  9:31 Saroj Mahapatra [this message]
2002-07-15 18:55 rob pike, esq.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d3220b4.0207121744.4fc802e6@posting.google.com \
    --to=saroj@optonline.net \
    --cc=9fans@cse.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).