From: quanstro@quanstro.net
To: 9fans@cse.psu.edu
Subject: Re: [9fans] page/png bug
Date: Sun, 9 Jul 2006 18:19:38 -0500 [thread overview]
Message-ID: <7334ec13de23c99f4ca85d53ae24df5d@quanstro.net> (raw)
In-Reply-To: <ee9e417a0607091152x550a39eejbc6cbc46c80e44bf@mail.gmail.com>
russ,
i posted a little bit on this. the problem is these two lines in png.c:
165 if(defaultcolor && screen->depth>8 && outchan==CMAP8)
166 outchan = RGB24;
if they are commented out (and i think if you replace RGB24 with RGBA32),
the image appears correctly. using the v flag also works (for the wrong reasons).
the problem is in the conversion from the ABGR rawimage to RGB24. i hadn't
narrowed down where the problem occurs.
- erik
On Sun Jul 9 13:55:28 CDT 2006, rsc@swtch.com wrote:
> Would you mind describing the bug beyond
> saying "look at this file"?
>
> Russ
prev parent reply other threads:[~2006-07-09 23:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-08 16:22 Federico G. Benavento
2006-07-09 18:52 ` Russ Cox
2006-07-09 19:09 ` Federico G. Benavento
2006-07-09 23:19 ` quanstro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7334ec13de23c99f4ca85d53ae24df5d@quanstro.net \
--to=quanstro@quanstro.net \
--cc=9fans@cse.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).