From mboxrd@z Thu Jan  1 00:00:00 1970
Message-ID: <76a3407a9a56c4130741b89d45774dda@quanstro.net>
From: erik quanstrom <quanstro@quanstro.net>
Date: Tue,  4 Aug 2009 05:04:06 -0400
To: 9fans@9fans.net
In-Reply-To: <856B4B8A-2383-4200-B93D-049B89FA6F10@storytotell.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Subject: Re: [9fans] Parallels Vesa driver question
Topicbox-Message-UUID: 37ca7b86-ead5-11e9-9d60-3106f5b1d025

> I fear I may not have applied the patch correctly:
>
> /sys/src/9/pc% mk CONF=pcf
> 8c -FTVw devarch.c
> devarch.c:733 not enough function arguments: cpuid
> devarch.c:733 argument prototype mismatch "IND ULONG" for "IND INT":
> cpuid
> devarch.c:739 argument prototype mismatch "INT" for "IND CHAR": cpuid
> devarch.c:739 not enough function arguments: cpuid
> devarch.c:739 argument prototype mismatch "IND ULONG" for "IND INT":
> cpuid
> devarch.c:869 function args not checked: mtrrprint
> devarch.c:951 function args not checked: mtrr
> mk: 8c -FTVw devarch.c  : exit status=rc 1227: 8c 1229: error
>
> I copied /n/sources/patch/saved/pat/*.[ch] to /sys/src/9/pc ... What
> is the correct procedure here?

your procedure was correct — assuming that the patch was made
against the current sources snapshot.  a more robust but
much more involved technique is to diff the x.c s against the x.c.orig s and
apply those diffs to your current setup.

i dropped a devarch.c in /n/sources/contrib/quanstro/devarch.c.  hopefully
that will make things easier.

- erik