From mboxrd@z Thu Jan  1 00:00:00 1970
From: erik quanstrom <quanstro@quanstro.net>
Date: Sun, 22 Jun 2014 20:57:44 -0400
To: 9fans@9fans.net
Message-ID: <77de0edfefe533821fb5106a4d24052b@mikro.quanstro.net>
In-Reply-To: <CAOw7k5iqEseXUW18L8Ww6E5xUgRdvQTSjB5pvCEUmaTWMSdtvQ@mail.gmail.com>
References: <EC073287-823A-4F0C-ACFD-2831DE775D53@fb.com>
	<1AE8E693-C840-4E40-BB19-6DF52A98E578@fb.com>
	<CAOw7k5iqEseXUW18L8Ww6E5xUgRdvQTSjB5pvCEUmaTWMSdtvQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Subject: Re: [9fans] bug in procwired() for x86 scheduler?
Topicbox-Message-UUID: fca5a7fc-ead8-11e9-9d60-3106f5b1d025

> On 22 June 2014 23:25, Yoann Padioleau <pad@fb.com> wrote:
>
> > if(up != p && (p->wired == nil || p->wired == MACHP(m->machno))
> >    m->readied = p;
> >
>
> yes, because on 386 m is effectively a constant. the code was written with
> extern register Mach *m in mind.
>


9atom has had it as

	if(up != p && (p->wired == nil || p->wired->machno == m->machno))

which i believe is equivalent, and less obnoxious.  the pc kernel should be rewritten
with the GS extern register bit, and then we could get rid of MACHP.

- erik