9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: Skip Tavakkolian <9nut@9netics.com>
To: 9fans@9fans.net
Subject: Re: [9fans] bug in authdial()
Date: Sat, 21 May 2016 14:45:04 -0700	[thread overview]
Message-ID: <79e6d7db8a4621d9a1305b0499c54a72@9netics.com> (raw)
In-Reply-To: <36c146b2e870849515a1677237037219@lilly.quanstro.net>

> a better solution is to just use waitmsg (see wait(2)).  the parsing rules and sizing are
> already implemented there.

yes, i agree. i changed my patch.

diff /n/dump/2016/0519/sys/src/libc/9sys/dial.c /sys/src/libc/9sys/dial.c
167c167
< notedeath(Dest *dp, char *exitsts)
---
> notedeath(Dest *dp, Waitmsg *exitsts)
169,170c169
< 	int i, n, pid;
< 	char *fields[5];			/* pid + 3 times + error */
---
> 	int n;
173,176c172
< 	for (i = 0; i < nelem(fields); i++)
< 		fields[i] = "";
< 	n = tokenize(exitsts, fields, nelem(fields));
< 	if (n < 4)
---
> 	if (exitsts->pid <= 0)
178,180d173
< 	pid = atoi(fields[0]);
< 	if (pid <= 0)
< 		return;
182c175
< 		if (conn->pid == pid && !conn->dead) {  /* it's one we know? */
---
> 		if (conn->pid == exitsts->pid && !conn->dead) {  /* it's one we know? */
187,188c180,182
< 			strncpy(conn->err, fields[4], sizeof conn->err - 1);
< 			conn->err[sizeof conn->err - 1] = '\0';
---
> 			n = strlen(exitsts->msg);
> 			assert(n < ERRMAX);
> 			strncpy(conn->err, exitsts->msg, n);
209c203
< 	char exitsts[2*ERRMAX];
---
> 	Waitmsg *exitsts = nil;
211c205
< 	if (outstandingprocs(dp) && await(exitsts, sizeof exitsts) >= 0) {
---
> 	if (outstandingprocs(dp) && (exitsts = wait()) != nil) {




  reply	other threads:[~2016-05-21 21:45 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-18  0:43 arisawa
2016-05-18  9:14 ` cinap_lenrek
2016-05-19 14:45   ` arisawa
2016-05-19 15:43     ` lucio
2016-05-19 15:48       ` Charles Forsyth
2016-05-20  4:58         ` arisawa
2016-05-20 22:04         ` Skip Tavakkolian
2016-05-20 22:25           ` Charles Forsyth
2016-05-21  4:46             ` arisawa
2016-05-21 17:04               ` erik quanstrom
2016-05-21 23:11                 ` Lyndon Nerenberg
2016-05-21 23:16                   ` erik quanstrom
2016-05-21 17:06             ` erik quanstrom
2016-05-21  3:24           ` arisawa
2016-05-23 14:27           ` arisawa
2016-05-20 22:07         ` Skip Tavakkolian
2016-05-21  2:25           ` Skip Tavakkolian
2016-05-21  7:00             ` arisawa
2016-05-21 16:51               ` erik quanstrom
2016-05-21 21:45                 ` Skip Tavakkolian [this message]
2016-05-21 21:48                   ` erik quanstrom
2016-05-21 22:16                     ` Skip Tavakkolian
2016-05-21 21:50                   ` erik quanstrom
2016-05-21 22:17                     ` Skip Tavakkolian
2016-05-21 22:34                       ` erik quanstrom
2016-05-21 23:03                         ` Skip Tavakkolian
2016-05-21 23:31                           ` erik quanstrom
2016-05-21 22:53                     ` David du Colombier
2016-05-18 13:06 ` Charles Forsyth
2016-05-18 17:03   ` Skip Tavakkolian
2016-05-19  4:07     ` arisawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79e6d7db8a4621d9a1305b0499c54a72@9netics.com \
    --to=9nut@9netics.com \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).