From mboxrd@z Thu Jan  1 00:00:00 1970
MIME-Version: 1.0
Date: Wed, 19 Aug 2009 15:02:52 -0700
Message-ID: <7d3530220908191502w35f099f1t29d285bb751add60@mail.gmail.com>
From: John Floren <slawmaster@gmail.com>
To: Fans of the OS Plan 9 from Bell Labs <9fans@9fans.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: [9fans] broken contrib source
Topicbox-Message-UUID: 4e817fe6-ead5-11e9-9d60-3106f5b1d025

Upon trying to build /sys/src/cmd for the arm today (beagleboards came
in), I found that mk was dying due to bad source installed by
contrib(1) packages. mk -k install was able to get me through most of
it, but the three worst offenders didn't even have mkfiles in their
top levels; since I didn't really care about having them, I deleted
the directories and continued. Those three offenders:
1. "contrib", which seems to have only one file in it.
2. "tcl"
3. "vim"

And, while it didn't bring mk -k to a grinding halt, I did notice
that, with nupas installed,  "cd /sys/src/cmd/upas; objtype=arm mk
install" chokes on /sys/src/cmd/upas/imap4.c/imap4.c.

Please, those of you who make contrib packages, don't dump source into
/sys/src without first checking that it can actually build! It's not
too difficult to do a "mk install" in /sys/src/cmd after you put the
source in there. Maybe there should be a contrib/verify script which
goes through /sys/src and makes sure everything can still build
normally?



John
--
"Object-oriented design is the roman numerals of computing" -- Rob Pike