From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <7dfb5c700d4fe23dedbb15cba8dfd966@gmx.de> To: 9fans@9fans.net Date: Mon, 19 Apr 2010 03:19:56 +0200 From: cinap_lenrek@gmx.de In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="upas-voqihxxufogsgtwtzbqlrnlpvc" Subject: Re: [9fans] multiple pings cause panic Topicbox-Message-UUID: 08688972-ead6-11e9-9d60-3106f5b1d025 This is a multi-part message in MIME format. --upas-voqihxxufogsgtwtzbqlrnlpvc Content-Disposition: inline Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit if one wants to retry connecting he can. not being able to make a network connection is a very common case so i guess it would be ok to simply let it fail on this point instead of hanging and waiting. rebooting sounds like a little bit too drastic for me. expecially if it is about icmp sockets. devip just has too less context to make a good decision. the comment above the panic call also hinted that it was ment as some kind of a bet or a debugging leftover so it felt save to remove it :) anyway. the patch may or may not get applied or someone comes up with a better solution. creating it was just a matter of seconds and i apologize for blocking the patch tu^W^Wqueue if it caused any inconvinience. :) -- panic("me is a boofhead"); --upas-voqihxxufogsgtwtzbqlrnlpvc Content-Type: message/rfc822 Content-Disposition: inline Return-Path: <9fans-bounces+cinap_lenrek=gmx.de@9fans.net> X-Flags: 0000 Delivered-To: GMX delivery to cinap_lenrek@gmx.de Received: (qmail invoked by alias); 19 Apr 2010 00:32:47 -0000 Received: from gouda.swtch.com (EHLO gouda.swtch.com) [67.207.142.3] by mx0.gmx.net (mx068) with SMTP; 19 Apr 2010 02:32:47 +0200 Received: from localhost ([127.0.0.1] helo=gouda.swtch.com) by gouda.swtch.com with esmtp (Exim 4.69) (envelope-from <9fans-bounces@9fans.net>) id 1O3esG-0000dK-CG; Mon, 19 Apr 2010 00:30:04 +0000 Received: from ladd.quanstro.net ([69.55.170.73]) by gouda.swtch.com with esmtp (Exim 4.69) (envelope-from ) id 1O3esD-0000dF-RM for 9fans@9fans.net; Mon, 19 Apr 2010 00:30:02 +0000 From: erik quanstrom Date: Sun, 18 Apr 2010 20:27:32 -0400 To: 9fans@9fans.net Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Subject: Re: [9fans] multiple pings cause panic X-BeenThere: 9fans@9fans.net X-Mailman-Version: 2.1.10 Precedence: list Reply-To: Fans of the OS Plan 9 from Bell Labs <9fans@9fans.net> List-Id: Fans of the OS Plan 9 from Bell Labs <9fans.9fans.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: 9fans-bounces@9fans.net Errors-To: 9fans-bounces+cinap_lenrek=gmx.de@9fans.net X-GMX-Antivirus: 0 (no virus found) X-GMX-Antispam: 0 (Sender is in whitelist: quanstro@quanstro.net); Detail=5D7Q89H36p4L00VTXC6D4q0N+AH0PUCnetdm6+jp8LEcjapYokC+U3v/81HGGfOKx+H8Q hsonGcD8c5YdwbU6cC26m7RS/IsV1; X-GMX-UID: m5b5eO1WPTRtaMh0kjIwAyYxc2tpZIvE > made a patch that changes the panic into a print: > > /n/sources/patch/devip-allconvused-panic i'm not sure that's what one wants, in general. depending on the protocol and the use case, you may want to (a) panic (b) print (carefully) (c) wait for the resource to become available. i'd be afraid of transforming a simple, automaticly recoverable problem into something that just wedges the machine with prints to the console and no progress. i've never seen a machine panic for this reason. - erik --upas-voqihxxufogsgtwtzbqlrnlpvc--