9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: adr <adr@SDF.ORG>
To: 9fans@9fans.net
Subject: [9fans] _threadmalloc() size>100000000; shouldn't be totalmalloc?
Date: Sun, 26 Jun 2022 09:50:19 +0000 (UTC)	[thread overview]
Message-ID: <7eea6efa-711a-31dc-031-dc5c2eddce3d@SDF.ORG> (raw)

/sys/src/libthread/lib.c

[...]
void*
_threadmalloc(long size, int z)
{
        void *m;

        m = malloc(size);
        if (m == nil)
                sysfatal("Malloc of size %ld failed: %r", size);
        setmalloctag(m, getcallerpc(&size));
        totalmalloc += size;
        if (size > 100000000) {
                fprint(2, "Malloc of size %ld, total %ld\n", size, totalmalloc);
                abort();
        }
        if (z)
                memset(m, 0, size);
        return m;
}
[...]

Shouldn't the if statement test the size of totalmalloc before the
abort? That size, 100M for internal allocations? It has to be
totalmalloc, doesn't it? If not this if statement should be after
testing the success of the malloc. Am I missing something?

adr.

------------------------------------------
9fans: 9fans
Permalink: https://9fans.topicbox.com/groups/9fans/Te1be8dc72738258d-M704d54262c512e9fce0f9fae
Delivery options: https://9fans.topicbox.com/groups/9fans/subscription

             reply	other threads:[~2022-06-26  9:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-26  9:50 adr [this message]
2022-06-28 13:00 ` [9fans] " adr
2022-06-28 13:50   ` Dan Cross
2022-06-28 14:21     ` adr
2022-06-28 14:32       ` Dan Cross
2022-06-28 15:36         ` adr
2022-06-28 15:57           ` Dan Cross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7eea6efa-711a-31dc-031-dc5c2eddce3d@SDF.ORG \
    --to=adr@sdf.org \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).