From mboxrd@z Thu Jan 1 00:00:00 1970 From: erik quanstrom Date: Thu, 18 Jul 2013 11:21:02 -0400 To: 9fans@9fans.net Message-ID: <809fd72c7b759ed6165ef1f95f3af11e@ladd.quanstro.net> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Subject: Re: [9fans] mallocz in APE Topicbox-Message-UUID: 6c93b406-ead8-11e9-9d60-3106f5b1d025 On Thu Jul 18 10:49:16 EDT 2013, steve@quintile.net wrote: > >> Having said this what about setmalloctag() getcallerpc(), etc etc. > > > >It is internal to the libraries and is not exposed to the APE apps, right? > > But because getcallerpc() is not prefexid by an underscore or file scope, > by the "rules" it is poluting the namespace of the APE app. > > Its a minor thing I know but somone put a lot of effort into adding _MALLOCZ() and > all the other internal funcs it seems a pity to not do the same with > setmalloctag() and getcallerpc(). unfortunately the ape libmp and libsec work has gotten a bit out of sync. i think patches have been submitted, but here's the state we're (9atom) at. mallocz is #defined to _MALLOCZ for internal use only. the reason for the #define is to avoid any additional source manipulation tricks for /sys/src/lib* source directly compiled as ape source. ; g mallocz /sys/src/ape/lib /sys/src/ape/lib/9/libc.h:149: #define mallocz _MALLOCZ ; nm /amd64/lib/ape/libsec.a|grep mallocz ; nm /amd64/lib/ape/libmp.a|grep mallocz ; nm /amd64/lib/ape/libauth.a|grep mallocz getcallerpc is not defined in any header files, so it shouldn't be a first-order issue. (there are so many of those to chose from!) there is no (get|set)(re)?alloctag in ape malloc, so questions about them are moot. - erik