From: erik quanstrom <quanstro@quanstro.net>
To: 9fans@9fans.net
Subject: Re: [9fans] cc nit?
Date: Sun, 1 Jul 2012 09:47:59 -0400 [thread overview]
Message-ID: <8312523b48f97b1a258bdcd06bb0eab8@brasstown.quanstro.net> (raw)
In-Reply-To: <20120630221505.8D6E2B82A@mail.bitblocks.com>
it's fixable with the following strategy
1. cc: for void's, don't emit anything from the compiler's acid generator
2. acid: accept empty aggrs.
i haven't pushed it to see if i can get acid to crash, and i don't have time
to right now, but this does improve the situation.
- erik
; diff -c /n/dump/2012/0701/sys/src/cmd/acid/dbg.y /sys/src/cmd/acid/dbg.y
/n/dump/2012/0701/sys/src/cmd/acid/dbg.y:75,82 - /sys/src/cmd/acid/dbg.y:75,85
zsemi :
| ';' zsemi
- members : member
- | members member
+ members :
+ {
+ $$ = nil;
+ }
+ | member members
{
$$ = an(OLIST, $1, $2);
}
; diff -c `{yesterday -n2 /sys/src/cmd/cc/acid.c} /sys/src/cmd/cc/acid.c
/n/dump/2012/0629/sys/src/cmd/cc/acid.c:112,117 - /sys/src/cmd/cc/acid.c:112,120
Bprint(&outbuf, " T%d\n", t->etype);
break;
+ case TVOID:
+ break; /* relies on acid being able to handle empty aggrs. */
+
case TIND:
if(s == S)
break;
next prev parent reply other threads:[~2012-07-01 13:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-30 21:25 erik quanstrom
2012-06-30 21:33 ` Bakul Shah
2012-06-30 21:37 ` erik quanstrom
2012-06-30 22:15 ` Bakul Shah
2012-07-01 13:47 ` erik quanstrom [this message]
2012-07-01 16:54 ` Comeau At9Fans
2012-07-01 20:39 ` Charles Forsyth
2012-07-01 22:22 ` Comeau At9Fans
2012-07-01 22:32 ` Charles Forsyth
2012-07-01 22:34 ` Charles Forsyth
2012-07-02 0:21 ` Comeau At9Fans
2012-07-02 0:18 ` Comeau At9Fans
2012-07-02 7:42 ` Charles Forsyth
2012-07-02 7:45 ` Charles Forsyth
[not found] ` <CAE9W7-iFxd6ysP4cxRcGVuLT0n+SY2r4XjOTVpjpXi292v4WWQ@mail.gmail.c>
2012-07-01 22:45 ` erik quanstrom
2012-07-02 0:24 ` Comeau At9Fans
[not found] ` <CAE9W7-gZsWHuspmwBw0qU_djkiDhAF6hA2zLU3Ms=xiO1j5LXQ@mail.gmail.c>
2012-07-01 16:57 ` erik quanstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8312523b48f97b1a258bdcd06bb0eab8@brasstown.quanstro.net \
--to=quanstro@quanstro.net \
--cc=9fans@9fans.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).