From mboxrd@z Thu Jan  1 00:00:00 1970
From: erik quanstrom <quanstro@quanstro.net>
Date: Sun,  1 Jul 2012 09:47:59 -0400
To: 9fans@9fans.net
Message-ID: <8312523b48f97b1a258bdcd06bb0eab8@brasstown.quanstro.net>
In-Reply-To: <20120630221505.8D6E2B82A@mail.bitblocks.com>
References: <19f6168fb6b109424ddbb1d276d62e6b@brasstown.quanstro.net>
	<20120630213344.4171DB827@mail.bitblocks.com>
	<c9c70b472e2a3d68dd25f5f850e0b8ef@brasstown.quanstro.net>
	<20120630221505.8D6E2B82A@mail.bitblocks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Subject: Re: [9fans] cc nit?
Topicbox-Message-UUID: a0757d46-ead7-11e9-9d60-3106f5b1d025

it's fixable with the following strategy
1.  cc: for void's, don't emit anything from the compiler's acid generator
2.  acid: accept empty aggrs.

i haven't pushed it to see if i can get acid to crash, and i don't have time
to right now, but this does improve the situation.

- erik

; diff -c /n/dump/2012/0701/sys/src/cmd/acid/dbg.y /sys/src/cmd/acid/dbg.y
/n/dump/2012/0701/sys/src/cmd/acid/dbg.y:75,82 - /sys/src/cmd/acid/dbg.y:75,85
  zsemi		:
  		| ';' zsemi

- members		: member
- 		| members member
+ members		:
+ 		{
+ 			$$ = nil;
+ 		}
+ 		| member members
  		{
  			$$ = an(OLIST, $1, $2);
  		}
; diff -c `{yesterday -n2 /sys/src/cmd/cc/acid.c} /sys/src/cmd/cc/acid.c
/n/dump/2012/0629/sys/src/cmd/cc/acid.c:112,117 - /sys/src/cmd/cc/acid.c:112,120
  		Bprint(&outbuf, "	T%d\n", t->etype);
  		break;

+ 	case TVOID:
+ 		break;		/* relies on acid being able to handle empty aggrs. */
+
  	case TIND:
  		if(s == S)
  			break;