9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: Lucio De Re <lucio@proxima.alt.za>
To: 9fans@9fans.net
Subject: Re: [9fans] ARM compiler shortcoming?
Date: Sat, 29 Oct 2011 18:18:31 +0200	[thread overview]
Message-ID: <86c35bb5d79536fa043abfb3dc02246d@proxima.alt.za> (raw)
In-Reply-To: <f9a4459b95d0a2b98e557cbd46acd811@chula.quanstro.net>

> /sys/src/cmd/cc/com64.c:275,281

The context is:

int
com64(Node *n)
{
	...
		switch(n->op) {
		default:
			diag(n, "unknown vlong %O", n->op);
		case OFUNC:
			n->complex = FNX;
		case ORETURN:
		case OAS:
		case OIND:
		case OLIST:
		case OCOMMA:
			return 1;
		case OADD:
			a = nodaddv;
			goto setbop;
		case OSUB:
	...
}

and it seems to me that a better answer would be to change the error
message to something like:

	"undefined 64-bit operation: %O"

I can't see much reason to stick to vlong when it is clear that 64-bit
handling is involved.

I do wonder why 8c isn't plagued by the same problem.

++L




  reply	other threads:[~2011-10-29 16:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-29 15:29 Lucio De Re
2011-10-29 15:25 ` erik quanstrom
2011-10-29 16:18   ` Lucio De Re [this message]
2011-10-29 16:28     ` Charles Forsyth
2011-10-29 16:42       ` Lucio De Re
2011-10-29 15:32 ` Charles Forsyth
2011-10-29 16:09   ` Lucio De Re
2011-10-29 16:09     ` Charles Forsyth
2011-10-29 16:40       ` Lucio De Re
2011-10-29 15:54 ` Charles Forsyth
2011-10-29 16:08   ` Lucio De Re

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86c35bb5d79536fa043abfb3dc02246d@proxima.alt.za \
    --to=lucio@proxima.alt.za \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).