9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: cinap_lenrek@felloff.net
To: 9fans@9fans.net
Subject: Re: [9fans] libmemlayer bug
Date: Mon,  9 Dec 2013 07:54:14 +0100	[thread overview]
Message-ID: <896d3ca2673efb8f934cfad41f38505f@felloff.net> (raw)
In-Reply-To: <d32e429baa9f831c3499136748fa7279@mikro>

that would mean chaning documented behaviour of drawclip()...

then i'd have to fix the callers of drawclip() as well.
keeping drawclip()'s behaviour as it is seemed to be the
safest option. and moving the source and mask rects to
src->r and mask->r makes sense in the context of working
on flat bitmaps.

there also was no way to fixup the result after drawclip() in
libmemlayers memdraw() without duplicating the functionaliry.

--
cinap



  reply	other threads:[~2013-12-09  6:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-09  4:09 cinap_lenrek
2013-12-09  4:43 ` Conor Williams
2013-12-09  5:00   ` cinap_lenrek
2013-12-09  5:28     ` Conor Williams
2013-12-09  6:09       ` Matthew Veety
2013-12-09  6:22         ` Conor Williams
2013-12-09  6:26           ` erik quanstrom
2013-12-09 13:05           ` Matthew Veety
2013-12-09  6:41 ` erik quanstrom
2013-12-09  6:54   ` cinap_lenrek [this message]
2014-01-15  6:06 ` Conor Williams
2014-01-15  7:52   ` cinap_lenrek
2014-01-15  8:30     ` Conor Williams
2014-01-15 14:42     ` erik quanstrom
2014-01-15 19:08       ` cinap_lenrek
2014-01-15 21:19         ` Conor Williams
2014-01-15 21:31           ` Conor Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=896d3ca2673efb8f934cfad41f38505f@felloff.net \
    --to=cinap_lenrek@felloff.net \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).