9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: erik quanstrom <quanstro@quanstro.net>
To: 9fans@9fans.net
Subject: Re: [9fans] Tdmaxpkt in usbehci (no html)
Date: Thu, 11 Apr 2013 09:05:57 -0400	[thread overview]
Message-ID: <89ec832d7e467386a2f36d83033d0c6b@kw.quanstro.net> (raw)
In-Reply-To: <trinity-4dc553a9-048b-4476-b21b-57056db11e8e-1365679501436@3capp-gmx-bs34>

> in the ehci driver, it uses:
>
> Tdmaxpkt = 0x5000, /* max buffer for a Td */
>
> a td has 5*4K pages giving the 20K above, but i think this only applies if the
> first pointer is page aligned (page offset = 0) so all the pages can be filled
> completely.
>
> The EHCI spec says this:
> "The buffer pointer list in the qTD is long enough to support a maximum transfer size of 20K bytes. This case
> occurs when all five buffer pointers are used and the first offset is zero. A qTD handles a 16Kbyte buffer
> with any starting buffer alignment."
>
> The buffer pointer isnt page aligned as far as i can see, so make Tdmaxpkt = 0x4000 instead?

i wonder if it would make more sense to align the buffer.

(the unaligned case for iso->data looks wierd, too.)

- erik



  reply	other threads:[~2013-04-11 13:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-11 11:25 cinap_lenrek
2013-04-11 13:05 ` erik quanstrom [this message]
2013-04-11 13:09   ` kernel panic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89ec832d7e467386a2f36d83033d0c6b@kw.quanstro.net \
    --to=quanstro@quanstro.net \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).