9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: cinap_lenrek@gmx.de
To: 9fans@9fans.net
Subject: Re: [9fans] rio in rio and ghost windows.
Date: Thu, 30 Apr 2009 23:28:39 +0200	[thread overview]
Message-ID: <8d83f9caf28fe304d64b9290d8e4e115@gmx.de> (raw)
In-Reply-To: <126a2f7d0904300307n318aa6a2mbbdc17995722abe9@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 846 bytes --]

sorry...  does it work when you run a graphical app that opens
/dev/mouse like games/catclock in the hidden window?

or try to move the hidden window by picking move from the menu and
point to the area of the hidden window?

more details of the bug:

whide() converts the w->i of a window in a offscreen image and puts
the window in the hidden[] array.  but how does the system ignore
that hidden window?  here is no check for hidden[] or flags that tell
that the window should be ignored...  the answer is w->screenr.
whide() from rio.c is setting w->screenr to ZR by doing wsendctlmsg(w,
Reshaped, ZR, i) so that the window gets not picked anymore by
wpointto(), but wresized() restores w->screenr causing the hidden
window to be an active target again.

the patch is in:

/n/sources/patch/rio-ghostwindows-fix

--
cinap

[-- Attachment #2: Type: message/rfc822, Size: 5875 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 1066 bytes --]

can't reproduce :( Native system on hp compaq workstation.

2009/4/28 <cinap_lenrek@gmx.de>

> Test case:
>
> draw a window... run rio
>
> inside that thing draw another window and hide it.
>
> now rezise the rio window.
>
> now, the region where the window was seems to eat
> mouse events, but the window is hidden.
>
> Fix:
>
> in rio.c:^resized, change this:
> ...
>                if(ishidden)
>                        im = allocimage(display, r, screen->chan, 0,
> DWhite);
>                else
>                        im = allocwindow(wscreen, r, Refbackup, DWhite);
>
> to this:
>
>                if(ishidden){
>                        im = allocimage(display, r, screen->chan, 0,
> DWhite);
>                        r = ZR;
>                }else
>                        im = allocwindow(wscreen, r, Refbackup, DWhite);
>
>
> can anyone confirm this and may make a patch?
>
> --
> cinap
>
>
>


-- 
С наилучшими пожеланиями
Жилкин Сергей
With best regards
Zhilkin Sergey

[-- Attachment #2.1.2: Type: text/html, Size: 1564 bytes --]

      reply	other threads:[~2009-04-30 21:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-27 23:27 cinap_lenrek
2009-04-28  0:48 ` erik quanstrom
2009-04-30 10:07 ` Sergey Zhilkin
2009-04-30 21:28   ` cinap_lenrek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d83f9caf28fe304d64b9290d8e4e115@gmx.de \
    --to=cinap_lenrek@gmx.de \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).