From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <8d83f9caf28fe304d64b9290d8e4e115@gmx.de> To: 9fans@9fans.net Date: Thu, 30 Apr 2009 23:28:39 +0200 From: cinap_lenrek@gmx.de In-Reply-To: <126a2f7d0904300307n318aa6a2mbbdc17995722abe9@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="upas-njmqcwsndkhfzdkobeuukonemi" Subject: Re: [9fans] rio in rio and ghost windows. Topicbox-Message-UUID: f49179d2-ead4-11e9-9d60-3106f5b1d025 This is a multi-part message in MIME format. --upas-njmqcwsndkhfzdkobeuukonemi Content-Disposition: inline Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit sorry... does it work when you run a graphical app that opens /dev/mouse like games/catclock in the hidden window? or try to move the hidden window by picking move from the menu and point to the area of the hidden window? more details of the bug: whide() converts the w->i of a window in a offscreen image and puts the window in the hidden[] array. but how does the system ignore that hidden window? here is no check for hidden[] or flags that tell that the window should be ignored... the answer is w->screenr. whide() from rio.c is setting w->screenr to ZR by doing wsendctlmsg(w, Reshaped, ZR, i) so that the window gets not picked anymore by wpointto(), but wresized() restores w->screenr causing the hidden window to be an active target again. the patch is in: /n/sources/patch/rio-ghostwindows-fix -- cinap --upas-njmqcwsndkhfzdkobeuukonemi Content-Type: message/rfc822 Content-Disposition: inline Return-Path: <9fans-bounces+cinap_lenrek=gmx.de@9fans.net> X-Flags: 0000 Delivered-To: GMX delivery to cinap_lenrek@gmx.de Received: (qmail invoked by alias); 30 Apr 2009 10:14:38 -0000 Received: from gouda.swtch.com (EHLO gouda.swtch.com) [67.207.142.3] by mx0.gmx.net (mx018) with SMTP; 30 Apr 2009 12:14:38 +0200 Received: from localhost ([127.0.0.1] helo=gouda.swtch.com) by gouda.swtch.com with esmtp (Exim 4.67) (envelope-from <9fans-bounces@9fans.net>) id 1LzTBS-00053N-Uq; Thu, 30 Apr 2009 10:08:03 +0000 Received: from mail-ew0-f174.google.com ([209.85.219.174]) by gouda.swtch.com with esmtp (Exim 4.67) (envelope-from ) id 1LzTBQ-00053I-At for 9fans@9fans.net; Thu, 30 Apr 2009 10:08:00 +0000 Received: by ewy22 with SMTP id 22so1827039ewy.0 for <9fans@9fans.net>; Thu, 30 Apr 2009 03:07:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.49.194 with SMTP id x44mr420407web.130.1241086074083; Thu, 30 Apr 2009 03:07:54 -0700 (PDT) In-Reply-To: <3a6d3a5410f853ec69856464cde840a5@gmx.de> References: <3a6d3a5410f853ec69856464cde840a5@gmx.de> From: Sergey Zhilkin Date: Thu, 30 Apr 2009 14:07:34 +0400 Message-ID: <126a2f7d0904300307n318aa6a2mbbdc17995722abe9@mail.gmail.com> To: Fans of the OS Plan 9 from Bell Labs <9fans@9fans.net> Content-Type: multipart/alternative; boundary=0016367f9b1494daf20468c2dee8 Subject: Re: [9fans] rio in rio and ghost windows. X-BeenThere: 9fans@9fans.net X-Mailman-Version: 2.1.9 Precedence: list Reply-To: Fans of the OS Plan 9 from Bell Labs <9fans@9fans.net> List-Id: Fans of the OS Plan 9 from Bell Labs <9fans.9fans.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: 9fans-bounces@9fans.net Errors-To: 9fans-bounces+cinap_lenrek=gmx.de@9fans.net X-GMX-Antivirus: 0 (no virus found) X-GMX-Antispam: 0 (Mail was not recognized as spam) X-GMX-UID: QA+YLQFEa0AoOp4o1jEzk3A3Njh6dI6H --0016367f9b1494daf20468c2dee8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable can't reproduce :( Native system on hp compaq workstation. 2009/4/28 > Test case: > > draw a window... run rio > > inside that thing draw another window and hide it. > > now rezise the rio window. > > now, the region where the window was seems to eat > mouse events, but the window is hidden. > > Fix: > > in rio.c:^resized, change this: > ... > if(ishidden) > im =3D allocimage(display, r, screen->chan, 0, > DWhite); > else > im =3D allocwindow(wscreen, r, Refbackup, DWhite); > > to this: > > if(ishidden){ > im =3D allocimage(display, r, screen->chan, 0, > DWhite); > r =3D ZR; > }else > im =3D allocwindow(wscreen, r, Refbackup, DWhite); > > > can anyone confirm this and may make a patch? > > -- > cinap > > > --=20 =D0=A1 =D0=BD=D0=B0=D0=B8=D0=BB=D1=83=D1=87=D1=88=D0=B8=D0=BC=D0=B8 =D0=BF= =D0=BE=D0=B6=D0=B5=D0=BB=D0=B0=D0=BD=D0=B8=D1=8F=D0=BC=D0=B8 =D0=96=D0=B8=D0=BB=D0=BA=D0=B8=D0=BD =D0=A1=D0=B5=D1=80=D0=B3=D0=B5=D0=B9 With best regards Zhilkin Sergey --0016367f9b1494daf20468c2dee8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable can't reproduce :( Native system on hp compaq workstation.

2009/4/28 <cinap_lenrek@gmx.de>
Test case:

draw a window... run rio

inside that thing draw another window and hide it.

now rezise the rio window.

now, the region where the window was seems to eat
mouse events, but the window is hidden.

Fix:

in rio.c:^resized, change this:
...
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if(ishidden)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0im =3D allocimage(display, r, screen->chan, 0, DWhite);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0else
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0im =3D allocwindow(wscreen, r, Refbackup, DWhite);

to this:

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if(ishidden){
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0im =3D allocimage(display, r, screen->chan, 0, DWhite);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0r =3D ZR;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}else
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0im =3D allocwindow(wscreen, r, Refbackup, DWhite);


can anyone confirm this and may make a patch?

--
cinap





--
=D0=A1 =D0=BD=D0= =B0=D0=B8=D0=BB=D1=83=D1=87=D1=88=D0=B8=D0=BC=D0=B8 =D0=BF=D0=BE=D0=B6=D0= =B5=D0=BB=D0=B0=D0=BD=D0=B8=D1=8F=D0=BC=D0=B8
=D0=96=D0=B8=D0=BB=D0=BA= =D0=B8=D0=BD =D0=A1=D0=B5=D1=80=D0=B3=D0=B5=D0=B9
With best regards
Z= hilkin Sergey
--0016367f9b1494daf20468c2dee8-- --upas-njmqcwsndkhfzdkobeuukonemi--