9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: erik quanstrom <quanstro@quanstro.net>
To: mischief@9.offblast.org, 9fans@9fans.net
Subject: Re: [9fans] Building Go/386
Date: Mon,  2 Sep 2013 20:28:52 -0400	[thread overview]
Message-ID: <97bd08b770c2ccd6ee5d62ff072745f7@brasstown.quanstro.net> (raw)
In-Reply-To: <20130902220856.GA6254@iota.offblast.org>

> the trouble here is that go's src/libmach/8obj.c has '#include
> "../cmd/8l/8.out.h"', and 8.out.h now has the newly added '#include
> "../ld/textflag.h"'.
> 
> i see now that the kernel source has an instance of this, in
> /sys/src/9/pc: 'fns.h:1: #include "../port/portfns.h"', but i'm not sure
> how that is treated differently from this situation.

it is different because -I../port is part of CFLAGS.

i've just verified that the plan 9 c compilers interpret relative
paths relative to the original source file, not any included files,
but -p interprets relative to the file doing the including.
imo the compilers should be fixed, but it might require a few
fixes.  the easiest (smallest delta) solution would be for
8.out.h to include "../../cmd/ld/textflag.h" instead of "../ld/textflag.h".

i suppose this is just another reason not to include include files. ☺

- erik



  reply	other threads:[~2013-09-03  0:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-31 14:36 lucio
2013-08-31 15:11 ` erik quanstrom
2013-08-31 17:09   ` lucio
2013-08-31 18:12   ` lucio
2013-08-31 21:16     ` erik quanstrom
2013-09-02 18:15       ` Nick Owens
2013-09-02 20:50         ` Rob Pike
2013-09-02 21:51           ` erik quanstrom
2013-09-02 22:08             ` Nick Owens
2013-09-03  0:28               ` erik quanstrom [this message]
2013-09-04  6:07         ` lucio
2013-09-07 11:19   ` Anthony Martin
2013-09-07 13:07     ` erik quanstrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97bd08b770c2ccd6ee5d62ff072745f7@brasstown.quanstro.net \
    --to=quanstro@quanstro.net \
    --cc=9fans@9fans.net \
    --cc=mischief@9.offblast.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).