From mboxrd@z Thu Jan  1 00:00:00 1970
Message-ID: <9b49a84ef166b76d95d7993851fdc1de@hamnavoe.demon.co.uk>
To: 9fans@cse.psu.edu
Subject: Re: [9fans] aha1542 -> kernel panic
From: Richard Miller <miller@hamnavoe.demon.co.uk>
In-Reply-To: <001e01c2b0eb$f756a8d0$78b5fc3e@swlocal>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Date: Wed,  1 Jan 2003 11:15:44 +0000
Topicbox-Message-UUID: 3a652c4c-eacb-11e9-9e20-41e7f4b1d025

> Without the scsi0=aha1542 port=0x330 in plan9.ini
> the machine boots fine.

There's the clue.  The plan9.ini line should be

scsi0=type=aha1542 port=0x330

Without the "type=" field, isa.type is left as a null pointer and
this line

		if(strcmp(isa.type, "aha1542"))
			continue;

causes the panic.

There are other places in the kernel where a similar panic could
occur.  In the absence of thorough syntax-checking of plan9.ini,
may I suggest adding a defensive

	isa->type = "";

to the beginning of /sys/src/9/pc/main.c:/^isaconfig/ ?

-- Richard Miller