9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: "Federico G. Benavento" <benavento@gmail.com>
To: Fans of the OS Plan 9 from Bell Labs <9fans@9fans.net>
Subject: Re: [9fans] thread STACK size
Date: Wed, 19 May 2010 06:55:25 -0300	[thread overview]
Message-ID: <AANLkTimbeopoAG6SebJTRdk2zHb9IeMh0CSckDHE-1hl@mail.gmail.com> (raw)
In-Reply-To: <8a7d369bb212b77cb4ca5c8b1408a267@plan9.bell-labs.com>

also if you're using bio(8) notice that a biobuf is >8kb

On Wed, May 19, 2010 at 6:20 AM, Sape Mullender
<sape@plan9.bell-labs.com> wrote:
>> A while ago, while working on btfs, I stumbled upon some sort of
>> overflow (http://9fans.net/archive/2009/07/77) which was in fact due
>> to the thread STACK being too small (and hence if I understood
>> correctly things would get written out of it, in the heap).
>> To be on the safe side, I have it set to 16384 now, but as I think I'm
>> getting near something usable with btfs, I'd like to go back to a more
>> fitting value. I think it's pretty important to have it as low as
>> possible since the number of threads/coroutines will grow linearly
>> with the number of peers connected (to be honest, I don't even know if
>> that can even scale in terms of memory use).
>>
>> So the question is, how can I evualuate what's the minimal value I can
>> set that to without getting into trouble again? Is there anything
>> smarter than just trial and error?
>
> There's no good way, really.  One thing you might do is change the thread
> library to initialize the stack to some pattern (zeroing it will probably
> do, but you can let your phantasy go wild here).  You can then, when your
> code has been running for a while, use acid -lthread and a bit of scripting
> to scan your stacks for the higest point where the pattern is disturbed.
>
>
> As a general rule in threaded programs, avoid declaring local arrays
> or large structs.  Instead, malloc them and free them when you're done.
> A file server, as an example, should never allocate an 8K message
> buffer on the stack.  If you can manage to obey the rule of not having
> arrays on the stack (as local variables), you can usually comfortably
> make use of 4K or 8K stacks.
>
>        Sape
>
>



-- 
Federico G. Benavento



  reply	other threads:[~2010-05-19  9:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-19  9:04 Mathieu Lonjaret
2010-05-19  9:20 ` Sape Mullender
2010-05-19  9:55   ` Federico G. Benavento [this message]
2010-05-19 10:51     ` Francisco J Ballesteros
2010-05-19 13:56   ` erik quanstrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTimbeopoAG6SebJTRdk2zHb9IeMh0CSckDHE-1hl@mail.gmail.com \
    --to=benavento@gmail.com \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).