From: Yoann Padioleau <pad@fb.com>
To: Fans of the OS Plan 9 from Bell Labs <9fans@9fans.net>
Subject: [9fans] kernel bug
Date: Tue, 3 Jun 2014 01:14:13 +0000 [thread overview]
Message-ID: <C29EB1DC-4A22-4149-9510-3054933D77C5@fb.com> (raw)
Hi,
in the newseg() function there is:
mapsize = ROUND(size, PTEPERTAB)/PTEPERTAB;
if(mapsize > nelem(s->ssegmap)){
mapsize *= 2;
if(mapsize > (SEGMAPSIZE*PTEPERTAB))
mapsize = (SEGMAPSIZE*PTEPERTAB);
s->map = smalloc(mapsize*sizeof(Pte*));
s->mapsize = mapsize;
}
else{
s->map = s->ssegmap;
s->mapsize = nelem(s->ssegmap);
}
I think it should be
if(mapsize > (SEGMAPSIZE))
mapsize = SEGMAPSIZE;
Also why in the kernel they use 'struct Pte' instead of the better name Pagetable.
In many places this is very confusing because when I see Pte I think of a Pagetable Entry
where really they are speaking about a Pagetable.
next reply other threads:[~2014-06-03 1:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 1:14 Yoann Padioleau [this message]
2014-06-03 5:49 ` cinap_lenrek
2014-06-03 6:00 ` Anthony Martin
2014-06-03 15:47 ` erik quanstrom
2014-06-03 15:56 ` andrey mirtchovski
2014-06-03 16:04 ` erik quanstrom
2014-06-04 19:12 ` Anthony Martin
2014-06-03 16:08 ` Charles Forsyth
2014-06-03 17:08 ` erik quanstrom
2014-06-03 18:04 ` Charles Forsyth
2014-06-03 18:09 ` Charles Forsyth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C29EB1DC-4A22-4149-9510-3054933D77C5@fb.com \
--to=pad@fb.com \
--cc=9fans@9fans.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).