9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: Jacob Moody <jsmoody@iastate.edu>
To: 9fans@9fans.net
Subject: [9fans] Acme resize bug
Date: Sun, 30 Dec 2018 16:22:39 -0600	[thread overview]
Message-ID: <CA+gzr0KC+Fg6AquDzWF0rQfwHNcxpPmQq7xJ6C7jY4z22R4ayQ@mail.gmail.com> (raw)

Hello 9fans,

I've noticed that sometimes when resizing acme columns there is a
strip left at the bottom that doesn't get redrawn.
It's a bit hard to notice with the default colours, but changing it up
makes it more obvious.
I was able to fix it with this the following patch but am not sure if
this is the best way to go about fixing it.

diff -u /dist/clean/plan9front/sys/src/cmd/acme/cols.c /sys/src/cmd/acme/cols.c
--- /dist/clean/plan9front/sys/src/cmd/acme/cols.c Thu Nov  1 15:02:44 2018
+++ /sys/src/cmd/acme/cols.c Thu Nov  1 15:38:53 2018
@@ -204,6 +204,7 @@
  draw(screen, r2, display->black, nil, ZP);
  r1.min.y = r2.max.y;
  r1.min.y = winresize(w, r1, FALSE);
+ draw(screen, r1, textcols[BACK], nil, ZP);
  }
  c->r = r;
 }

Happy New Year,
Moody



             reply	other threads:[~2018-12-30 22:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-30 22:22 Jacob Moody [this message]
2018-12-31 10:17 ` Ethan Gardener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+gzr0KC+Fg6AquDzWF0rQfwHNcxpPmQq7xJ6C7jY4z22R4ayQ@mail.gmail.com \
    --to=jsmoody@iastate.edu \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).