9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: Mark Bucciarelli <mkbucc@gmail.com>
To: Fans <9fans@9fans.net>
Subject: [9fans] How to submit a patch for 9fans.net/go/plan9/client?
Date: Mon,  7 Sep 2015 21:54:10 -0400	[thread overview]
Message-ID: <CAFqAhKriF4VBUrv+ZVpRU01-BEbvwLaxdSbfA6akOwqn9L-gtg@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

Hi,

I'd like to fix the XXX at
https://github.com/9fans/go/blob/master/plan9/client/conn.go#L41-L46.  Per
the man page, version should send a tag of NOTAG, and it currently sends a
1.  Making it so, and then replacing the rpc() call with c.write followed
by a c.read should do the trick.

How do I submit a patch?  I see forks on github, but no one merging back to
9fans.  Is there a codereview link somewhere I should use?  Or just a
normal github pull request.

Thanks,

Mark

[-- Attachment #2: Type: text/html, Size: 689 bytes --]

             reply	other threads:[~2015-09-08  1:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-08  1:54 Mark Bucciarelli [this message]
2015-09-09  3:29 ` Skip Tavakkolian
2015-09-09  4:27   ` lucio
2015-09-09  7:52     ` Jeremy Jackins
2015-09-09  9:43       ` lucio
2015-09-09  9:59       ` Aram Hăvărneanu
2015-09-09 23:48         ` Mark Bucciarelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFqAhKriF4VBUrv+ZVpRU01-BEbvwLaxdSbfA6akOwqn9L-gtg@mail.gmail.com \
    --to=mkbucc@gmail.com \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).