> It is the Plan 9 Way (TM) to avoid > nested inclusion of header files,

$ arch/dat.h includes port/portdat.h in kernel. Exempted too?

Álvaro Jurado Cuevas
http://colmenar.biz.tm

El 30/05/2015 07:11, <lucio@proxima.alt.za> escribió:
> Which version?
>
> "The id_t and pid_t types shall be defined as described in
> <sys/types.h>." in issue 6
>
> "The <sys/wait.h> header shall define the id_t and pid_t types as
> described in <sys/types.h>." in issue 7
>
> in the sys/wait.h part of the headers section of base definitions

I haven't looked at cinap's work, but...

It is the Plan 9 Way (TM) to avoid nested inclusion of header files,
although I guess the APE may be exempted.  I also appreciate that
adding conditional definitions of id_t and pid_t in <sys/wait.h> that
match those in <sys/types.h> could lead to eventual inconsistencies,
but I would still prefer to follow the Plan 9 guidelines.

But without a more formal code review structure and the apparent
absence of guidance from Bell Labs, I suppose I'm just farting in the
wind.

Lucio.