From mboxrd@z Thu Jan  1 00:00:00 1970
MIME-Version: 1.0
In-Reply-To: <AA00716C-7B8A-43A1-8B53-4454016F16B2@fb.com>
References: <AA00716C-7B8A-43A1-8B53-4454016F16B2@fb.com>
From: Rob Pike <robpike@gmail.com>
Date: Tue, 14 Oct 2014 15:45:48 -0700
Message-ID: <CAKzdPgxbh7OSisQCO9pJryTFV_mbf0413xBjYVoSvLq+LQ-z4w@mail.gmail.com>
To: Fans of the OS Plan 9 from Bell Labs <9fans@9fans.net>
Content-Type: multipart/alternative; boundary=089e0158be220fb091050569c886
Subject: Re: [9fans] copy paste bug in cc.y?
Topicbox-Message-UUID: 1cd31fd2-ead9-11e9-9d60-3106f5b1d025

--089e0158be220fb091050569c886
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Looks like it.

-rob


On Tue, Oct 14, 2014 at 3:11 PM, Yoann Padioleau <pad@fb.com> wrote:

>  Hi,
>
>  It=E2=80=99s a copy paste bug here right?
> https://code.google.com/p/ken-cc/source/browse/src/cmd/cc/cc.y#476
>
>
>    |       LSWITCH '(' cexpr ')' stmnt
>           {
>                   $$ =3D new(OCONST, Z, Z);
>                   $$->vconst =3D 0;
>                   $$->type =3D types[TINT];
>                   $3 =3D new(OSUB, $$, $3);
>
>                   $$ =3D new(OCONST, Z, Z);
>                   $$->vconst =3D 0;
>                   $$->type =3D types[TINT];
>                   $3 =3D new(OSUB, $$, $3);
>
>                   $$ =3D new(OSWITCH, $3, $5);
>           }
>
>
>

--089e0158be220fb091050569c886
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Looks like it.<div><br></div><div>-rob</div><div><br></div=
></div><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">On Tue, Oc=
t 14, 2014 at 3:11 PM, Yoann Padioleau <span dir=3D"ltr">&lt;<a href=3D"mai=
lto:pad@fb.com" target=3D"_blank">pad@fb.com</a>&gt;</span> wrote:<br><bloc=
kquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #cc=
c solid;padding-left:1ex">



<div style=3D"word-wrap:break-word">
Hi,
<div><br>
</div>
<div>It=E2=80=99s a copy paste bug here right?</div>
<div><a href=3D"https://code.google.com/p/ken-cc/source/browse/src/cmd/cc/c=
c.y#476" target=3D"_blank">https://code.google.com/p/ken-cc/source/browse/s=
rc/cmd/cc/cc.y#476</a></div>
<div><br>
</div>
<div><br>
</div>
<div>
<table style=3D"border-collapse:collapse;padding:0px;margin:0px;color:rgb(0=
,0,0);font-family:Monaco,&#39;DejaVu Sans Mono&#39;,&#39;Bitstream Vera San=
s Mono&#39;,&#39;Lucida Console&#39;,monospace;font-size:12px;white-space:p=
re-wrap;background-color:rgb(255,255,255)">
<tbody style=3D"padding:0px;margin:0px">
<tr style=3D"padding:0px;margin:0px">
<td style=3D"padding:0px 0px 0px 4px;margin:0px;white-space:pre-wrap;vertic=
al-align:top">
<span style=3D"color:rgb(102,102,0)">|</span><span> =C2=A0 =C2=A0 =C2=A0 LS=
WITCH
</span><span style=3D"color:rgb(0,136,0)">&#39;(&#39;</span><span> cexpr
</span><span style=3D"color:rgb(0,136,0)">&#39;)&#39;</span><span> stmnt<br=
>
</span></td>
</tr>
<tr style=3D"padding:0px;margin:0px">
<td style=3D"padding:0px 0px 0px 4px;margin:0px;white-space:pre-wrap;vertic=
al-align:top">
<span>=C2=A0 =C2=A0 =C2=A0 =C2=A0 </span><span style=3D"color:rgb(102,102,0=
)">{</span><span><br>
</span></td>
</tr>
<tr style=3D"padding:0px;margin:0px">
<td style=3D"padding:0px 0px 0px 4px;margin:0px;white-space:pre-wrap;vertic=
al-align:top">
<span>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $$ </span><sp=
an style=3D"color:rgb(102,102,0)">=3D</span><span>
</span><span style=3D"color:rgb(0,0,136)">new</span><span style=3D"color:rg=
b(102,102,0)">(</span><span>OCONST</span><span style=3D"color:rgb(102,102,0=
)">,</span><span> Z</span><span style=3D"color:rgb(102,102,0)">,</span><spa=
n>
 Z</span><span style=3D"color:rgb(102,102,0)">);</span><span><br>
</span></td>
</tr>
<tr style=3D"padding:0px;margin:0px">
<td style=3D"padding:0px 0px 0px 4px;margin:0px;white-space:pre-wrap;vertic=
al-align:top">
<span>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $$</span><spa=
n style=3D"color:rgb(102,102,0)">-&gt;</span><span>vconst
</span><span style=3D"color:rgb(102,102,0)">=3D</span><span>
</span><span style=3D"color:rgb(0,102,102)">0</span><span style=3D"color:rg=
b(102,102,0)">;</span><span><br>
</span></td>
</tr>
<tr style=3D"padding:0px;margin:0px">
<td style=3D"padding:0px 0px 0px 4px;margin:0px;white-space:pre-wrap;vertic=
al-align:top">
<span>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $$</span><spa=
n style=3D"color:rgb(102,102,0)">-&gt;</span><span>type
</span><span style=3D"color:rgb(102,102,0)">=3D</span><span> types</span><s=
pan style=3D"color:rgb(102,102,0)">[</span><span>TINT</span><span style=3D"=
color:rgb(102,102,0)">];</span><span><br>
</span></td>
</tr>
<tr style=3D"padding:0px;margin:0px">
<td style=3D"padding:0px 0px 0px 4px;margin:0px;white-space:pre-wrap;vertic=
al-align:top">
<span>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $3 </span><sp=
an style=3D"color:rgb(102,102,0)">=3D</span><span>
</span><span style=3D"color:rgb(0,0,136)">new</span><span style=3D"color:rg=
b(102,102,0)">(</span><span>OSUB</span><span style=3D"color:rgb(102,102,0)"=
>,</span><span> $$</span><span style=3D"color:rgb(102,102,0)">,</span><span=
>
 $3</span><span style=3D"color:rgb(102,102,0)">);</span><span><br>
</span></td>
</tr>
<tr style=3D"padding:0px;margin:0px">
<td style=3D"padding:0px 0px 0px 4px;margin:0px;white-space:pre-wrap;vertic=
al-align:top">
<span><br>
</span></td>
</tr>
<tr style=3D"padding:0px;margin:0px">
<td style=3D"padding:0px 0px 0px 4px;margin:0px;white-space:pre-wrap;vertic=
al-align:top">
<span>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $$ </span><sp=
an style=3D"color:rgb(102,102,0)">=3D</span><span>
</span><span style=3D"color:rgb(0,0,136)">new</span><span style=3D"color:rg=
b(102,102,0)">(</span><span>OCONST</span><span style=3D"color:rgb(102,102,0=
)">,</span><span> Z</span><span style=3D"color:rgb(102,102,0)">,</span><spa=
n>
 Z</span><span style=3D"color:rgb(102,102,0)">);</span><span><br>
</span></td>
</tr>
<tr style=3D"padding:0px;margin:0px">
<td style=3D"padding:0px 0px 0px 4px;margin:0px;white-space:pre-wrap;vertic=
al-align:top">
<span>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $$</span><spa=
n style=3D"color:rgb(102,102,0)">-&gt;</span><span>vconst
</span><span style=3D"color:rgb(102,102,0)">=3D</span><span>
</span><span style=3D"color:rgb(0,102,102)">0</span><span style=3D"color:rg=
b(102,102,0)">;</span><span><br>
</span></td>
</tr>
<tr style=3D"padding:0px;margin:0px">
<td style=3D"padding:0px 0px 0px 4px;margin:0px;white-space:pre-wrap;vertic=
al-align:top">
<span>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $$</span><spa=
n style=3D"color:rgb(102,102,0)">-&gt;</span><span>type
</span><span style=3D"color:rgb(102,102,0)">=3D</span><span> types</span><s=
pan style=3D"color:rgb(102,102,0)">[</span><span>TINT</span><span style=3D"=
color:rgb(102,102,0)">];</span><span><br>
</span></td>
</tr>
<tr style=3D"padding:0px;margin:0px">
<td style=3D"padding:0px 0px 0px 4px;margin:0px;white-space:pre-wrap;vertic=
al-align:top">
<span>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $3 </span><sp=
an style=3D"color:rgb(102,102,0)">=3D</span><span>
</span><span style=3D"color:rgb(0,0,136)">new</span><span style=3D"color:rg=
b(102,102,0)">(</span><span>OSUB</span><span style=3D"color:rgb(102,102,0)"=
>,</span><span> $$</span><span style=3D"color:rgb(102,102,0)">,</span><span=
>
 $3</span><span style=3D"color:rgb(102,102,0)">);</span><span><br>
</span></td>
</tr>
<tr style=3D"padding:0px;margin:0px">
<td style=3D"padding:0px 0px 0px 4px;margin:0px;white-space:pre-wrap;vertic=
al-align:top">
<span><br>
</span></td>
</tr>
<tr style=3D"padding:0px;margin:0px">
<td style=3D"padding:0px 0px 0px 4px;margin:0px;white-space:pre-wrap;vertic=
al-align:top">
<span>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $$ </span><sp=
an style=3D"color:rgb(102,102,0)">=3D</span><span>
</span><span style=3D"color:rgb(0,0,136)">new</span><span style=3D"color:rg=
b(102,102,0)">(</span><span>OSWITCH</span><span style=3D"color:rgb(102,102,=
0)">,</span><span> $3</span><span style=3D"color:rgb(102,102,0)">,</span><s=
pan>
 $5</span><span style=3D"color:rgb(102,102,0)">);</span><span><br>
</span></td>
</tr>
<tr style=3D"padding:0px;margin:0px">
<td style=3D"padding:0px 0px 0px 4px;margin:0px;white-space:pre-wrap;vertic=
al-align:top">
<span>=C2=A0 =C2=A0 =C2=A0 =C2=A0 </span><span style=3D"color:rgb(102,102,0=
)">}</span></td>
</tr>
</tbody>
</table>
<div><br>
</div>
</div>
<div><br>
</div>
</div>

</blockquote></div><br></div>

--089e0158be220fb091050569c886--