Re: [9fans] file descriptor leak

[Charles Forsyth <charles.forsyth@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]

On 16 February 2016 at 18:01, <cinap_lenrek@felloff.net> wrote:

> and the parent proc doesnt need the fd to /dev/null, it could as well just
> open it in the child like:
>
> close(0); open("/dev/null", OREAD);
>
>
There's no harm in making and using a more general function, even in a
specific way, so that part's ok.
The caller just needs to play its part properly.

after spending 5 minutes writing the code fixing all these issues mentiond
> above, i'll just throw it all away and delete the whole remounting logic
> for /net.alt in 9front.


It's often better to use the Erlang fail-fast ("just fail") and restart
approach for persistent services.

More important would be to look at /proc/N/fd on a failing system.
I've a feeling that the system/outside stuff isn't actually the problem,
since I've seen the diagnostic on a system that wasn't using /net.alt.
In that case, the problem (as I remember it) was that an Internet link
further on was down,
so no messages got through to remote DNS, and file descriptors were
building up in slave processes
waiting for replies on /net/udp. Once the link was up, it went back to
normal.

[-- Attachment #2: Type: text/html, Size: 2339 bytes --]