From mboxrd@z Thu Jan 1 00:00:00 1970 Message-Id: From: Pietro Gagliardi To: Fans of the OS Plan 9 from Bell Labs <9fans@9fans.net> In-Reply-To: <0d3afe4bf8b675ccc673041bc78bb94c@csplan9.rit.edu> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v919.2) Date: Tue, 15 Apr 2008 18:40:52 -0400 References: <0d3afe4bf8b675ccc673041bc78bb94c@csplan9.rit.edu> Subject: Re: [9fans] sshserve.c Topicbox-Message-UUID: 8e9d4efe-ead3-11e9-9d60-3106f5b1d025 On Apr 15, 2008, at 6:34 PM, john@csplan9.rit.edu wrote: >> Yup. usage() is calling itself with no termination condition - and >> what's more, it is tail recursing. It should be >> >> void >> usage(void) >> { >> fprint(2, "usage: sshserve [-A authlist] [-c cipherlist] client-ip- >> address\n"); >> exits("usage"); >> } >> >> to keep with the Plan 9 program. Enjoy! >> >> When this QEMU-on-Leopard-freezes-randomly bug gets fixed, I can fix >> it and any other dangers. >> >> On Apr 15, 2008, at 6:05 PM, Kenji Arisawa wrote: >> >>> Hello, >>> >>> In sshserve.c: >>> >>> void >>> usage(void) >>> { >>> fprint(2, "usage: sshserve [-A authlist] [-c cipherlist] client-ip- >>> address\n"); >>> usage(); >>> } >>> >>> This code can make endless loop. Right? >>> >>> Kenji Arisawa >>> >>> > > Submit a patch! > And don't top-post, damn it. We aren't all MicroSavages here. > > > John > > I'm on OS X, and again, I can't have QEMU crash just before rio starts!\