From mboxrd@z Thu Jan  1 00:00:00 1970
Message-Id: <D4577BBF-4E57-4C91-AE3A-51586C315028@mac.com>
From: Pietro Gagliardi <pietro10@mac.com>
To: Fans of the OS Plan 9 from Bell Labs <9fans@9fans.net>
In-Reply-To: <EAF5F709-3150-4FAC-8BE9-8E476789A246@ar.aichi-u.ac.jp>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v919.2)
Date: Tue, 15 Apr 2008 18:29:38 -0400
References: <EAF5F709-3150-4FAC-8BE9-8E476789A246@ar.aichi-u.ac.jp>
Subject: Re: [9fans] sshserve.c
Topicbox-Message-UUID: 8e90713e-ead3-11e9-9d60-3106f5b1d025

Yup. usage() is calling itself with no termination condition - and
what's more, it is tail recursing. It should be

	void
	usage(void)
	{
		fprint(2, "usage: sshserve [-A authlist] [-c cipherlist] client-ip-
address\n");
		exits("usage");
	}

to keep with the Plan 9 program. Enjoy!

When this QEMU-on-Leopard-freezes-randomly bug gets fixed, I can fix
it and any other dangers.

On Apr 15, 2008, at 6:05 PM, Kenji Arisawa wrote:

> Hello,
>
> In sshserve.c:
>
> void
> usage(void)
> {
> 	fprint(2, "usage: sshserve [-A authlist] [-c cipherlist] client-ip-
> address\n");
> 	usage();
> }
>
> This code can make endless loop. Right?
>
> Kenji Arisawa
>
>