From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: * X-Spam-Status: No, score=1.4 required=5.0 tests=DATE_IN_FUTURE_03_06, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2 autolearn=no autolearn_force=no version=3.4.4 Received: (qmail 31079 invoked from network); 4 Apr 2023 18:19:12 -0000 Received: from tb-ob20.topicbox.com (173.228.157.66) by inbox.vuxu.org with ESMTPUTF8; 4 Apr 2023 18:19:12 -0000 Received: from tb-mx1.topicbox.com (tb-mx1.nyi.icgroup.com [10.90.30.61]) by tb-ob20.topicbox.com (Postfix) with ESMTP id 2F14829F57 for ; Tue, 4 Apr 2023 14:19:08 -0400 (EDT) (envelope-from bounce.mM4de9844d7316ae1c346391d7.r522be890-2105-11eb-b15e-8d699134e1fa@9fans.bounce.topicbox.com) Received: by tb-mx1.topicbox.com (Postfix, from userid 1132) id 3231017A9F29; Tue, 4 Apr 2023 14:19:08 -0400 (EDT) ARC-Authentication-Results: i=2; topicbox.com; arc=pass; dkim=pass (2048-bit rsa key sha256) header.d=pixelhero.dev header.i=@pixelhero.dev header.b=krmP0ptT header.a=rsa-sha256 header.s=key1 x-bits=2048; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=pixelhero.dev; spf=pass smtp.mailfrom=noam@pixelhero.dev smtp.helo=out-23.mta0.migadu.com; x-internal-arc=fail (as.1.topicbox.com=pass, ams.1.topicbox.com=fail (message has been altered)) (Message modified while forwarding at Topicbox) ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=message-id:to:subject:date:from:in-reply-to :mime-version:content-type:content-transfer-encoding:list-help :list-id:list-post:list-subscribe:reply-to:list-unsubscribe; s= sysmsg-1; t=1680632348; bh=6yZA7wZ0pux5YP10wx/6XSJ015BOFyV1te8Cb hDa8c0=; b=FvsUJHrLoO1THfF1gheC6lsCIuWo6YhmEvk6r8ud8+q5IDvDvVJpE u5PN8FWk0OZLzVto0XEvxkn9+UW9qTRjU4/pXLIoyEOJoZNk/h84CvlgtUp9htkW fJGndWbeNqPfuxAf6YbnJ1/7HCfwd6+wDHpdlMmKnjN6vy/fB6JO2Q= ARC-Seal: i=2; a=rsa-sha256; cv=pass; d=topicbox.com; s=sysmsg-1; t= 1680632348; b=HNk1n3ZxtEb8aOZawJRwSwYcgjyIE59/JTLTQ7v7emMN73hEWr 89qkfIAzZomK1htiDzNT1OQMfagVgfUHVv01e8xyWE6sbmE8WaYxyPhXvpJq42MU empEbL9QLcj84BartpN45MpnsaA+1/EZFPfGdF879+XpuWmhgO9Ph9Wtw= Authentication-Results: topicbox.com; arc=pass; dkim=pass (2048-bit rsa key sha256) header.d=pixelhero.dev header.i=@pixelhero.dev header.b=krmP0ptT header.a=rsa-sha256 header.s=key1 x-bits=2048; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=pixelhero.dev; spf=pass smtp.mailfrom=noam@pixelhero.dev smtp.helo=out-23.mta0.migadu.com; x-internal-arc=fail (as.1.topicbox.com=pass, ams.1.topicbox.com=fail (message has been altered)) (Message modified while forwarding at Topicbox) X-Received-Authentication-Results: tb-mx1.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=pass (2048-bit rsa key sha256) header.d=pixelhero.dev header.i=@pixelhero.dev header.b=krmP0ptT header.a=rsa-sha256 header.s=key1 x-bits=2048; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=pixelhero.dev; iprev=pass smtp.remote-ip=91.218.175.23 (out-23.mta0.migadu.com); spf=pass smtp.mailfrom=noam@pixelhero.dev smtp.helo=out-23.mta0.migadu.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=out-23.mta0.migadu.com policy.ptr=out-23.mta0.migadu.com; x-return-mx=pass header.domain=pixelhero.dev policy.is_org=yes (MX Records found: aspmx2.migadu.com,aspmx1.migadu.com); x-return-mx=pass smtp.domain=pixelhero.dev policy.is_org=yes (MX Records found: aspmx2.migadu.com,aspmx1.migadu.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=9fans.net; h=message-id :to:subject:date:from:in-reply-to:mime-version:content-type :content-transfer-encoding:list-help:list-id:list-post :list-subscribe:reply-to:list-unsubscribe; s=dkim-1; t= 1680632348; x=1680718748; bh=DIpBZhOOBpZ3BgMw/Y7F2oI5xKgAIPaYGNH 5k6wzQA0=; b=BP1Yn7Nt0TmiePsn86B9meAW1P24elCkCEaS+ZOC9KBhriKx+Z5 Y7lW6jKJ8XW4KN1CtV4NQz33K9J6PDYfjMuxM+dAzYt4R/7mv6nHWr5GrJnSP33H VbyW8Vttku0GAXxaFrRwEDQ1vkn4xd08/GjnORh951QDXtCuwnPfoCLk= Received: from tb-mx1.topicbox.com (localhost.local [127.0.0.1]) by tb-mx1.topicbox.com (Postfix) with ESMTP id 91D7417A9AEE for <9fans@9fans.net>; Tue, 4 Apr 2023 14:18:54 -0400 (EDT) (envelope-from noam@pixelhero.dev) Received: from tb-mx1.topicbox.com (localhost [127.0.0.1]) by tb-mx1.topicbox.com (Authentication Milter) with ESMTP id DE8585F86F1; Tue, 4 Apr 2023 14:18:54 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1680632334; b=lK5nEdcqOU5iNlFiFxA8uFuSDAg3sVBgNabcLoL6bwMjqzmJNQ AaQB+jPhESSpUr6WwAr7jIZzPpHSqtg4mgwhu7aZDi+Aw4Xdj8DPK5aOzORO1/7J iUZqggtIdz4xVh0NMGG0/4f5kKq+bAGKTIOUZVSwi0o8GMArUWNH5G+9xMvlXK4t tMeHo+LK52JjQQTMIL6hZnkJQpbJG55fYc5tQsgHLJdWmRy6/JSzduR6sQZiuSEj 99M4g4OTf+WK9YyVlz0RgLjyNyr6zhYJ4I8r1D5d/3AxW4MjI9Qko58qe2oo85O0 gmY/31gEDlXrWyKFuAMrBy5pxEQbtpHScMjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=message-id:to:subject:date:from:in-reply-to :mime-version:content-type:content-transfer-encoding; s=arcseal; t=1680632334; bh=Qj/hNvdGXpG5p0FTfHTrhreSz7muCbmeqjiBWHnZ3l0=; b= G8T878cmzRKOW4HVDHjItLoAt8oGSoeMiE/fKlSAtghnyG2tGc+Djyzhzkn1wm6u gkTtwLTMNHH3QYtKxXXFmhwYADupRJWT6qovrD+xFwOvcyhipRQS8Db40P4/xunG nd5TILW2KhupWYkj39K5I6nYQ4C2Enj+8/tY/5wv/kgPkZqZj8wgE4ppQP+VYgSa ct7AIYBUJJzNDwk4g3dK5qCaHOASPrWDxlemRCItDUXjg0gHgTXClcdOpqA3UPfc xh/kkuP5dpk0R96JH3tS0550zwaOC8SMIreWkBbwN7zgOrEcLcD4PHCwjjVZlsSf amMbPwooB6TfFwREfNZw1A== ARC-Authentication-Results: i=1; tb-mx1.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=pass (2048-bit rsa key sha256) header.d=pixelhero.dev header.i=@pixelhero.dev header.b=krmP0ptT header.a=rsa-sha256 header.s=key1 x-bits=2048; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=pixelhero.dev; iprev=pass smtp.remote-ip=91.218.175.23 (out-23.mta0.migadu.com); spf=pass smtp.mailfrom=noam@pixelhero.dev smtp.helo=out-23.mta0.migadu.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=out-23.mta0.migadu.com policy.ptr=out-23.mta0.migadu.com; x-return-mx=pass header.domain=pixelhero.dev policy.is_org=yes (MX Records found: aspmx2.migadu.com,aspmx1.migadu.com); x-return-mx=pass smtp.domain=pixelhero.dev policy.is_org=yes (MX Records found: aspmx2.migadu.com,aspmx1.migadu.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeiledguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhepkffvuf ffhfgjgggtgfesthejjedttddtvdenucfhrhhomhepnhhorghmsehpihigvghlhhgvrhho rdguvghvnecuggftrfgrthhtvghrnhepueefjeefudejkeduudehkeejkeejjeevteefhf egleffkeekleeludejfeffgfetnecukfhppeeluddrvddukedrudejhedrvdefnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurddvudekrddujeehrd dvfedphhgvlhhopehouhhtqddvfedrmhhtrgdtrdhmihhgrgguuhdrtghomhdpmhgrihhl fhhrohhmpeeonhhorghmsehpihigvghlhhgvrhhordguvghvqe X-ME-VSScore: 0 X-ME-VSCategory: clean Received-SPF: pass (pixelhero.dev: Sender is authorized to use 'noam@pixelhero.dev' in 'mfrom' identity (mechanism 'include:spf.migadu.com' matched)) receiver=tb-mx1.topicbox.com; identity=mailfrom; envelope-from="noam@pixelhero.dev"; helo=out-23.mta0.migadu.com; client-ip=91.218.175.23 Received: from out-23.mta0.migadu.com (out-23.mta0.migadu.com [91.218.175.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx1.topicbox.com (Postfix) with ESMTPS for <9fans@9fans.net>; Tue, 4 Apr 2023 14:18:53 -0400 (EDT) (envelope-from noam@pixelhero.dev) Message-ID: To: 9fans@9fans.net Subject: Re: [9fans] [PATCH] fossil: fix a deadlock in the caching logic Date: Tue, 04 Apr 2023 18:15:13 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: noam@pixelhero.dev In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: 2afa8b22-d315-11ed-b83c-acd888a1bfdc Archived-At: =?UTF-8?B?PGh0dHBzOi8vOWZhbnMudG9waWNib3guY29tL2dyb3Vwcy85?= =?UTF-8?B?ZmFucy9UMzU0ZmU3MDJlMWU5ZDVlOS1NNGRlOTg0NGQ3MzE2YWUxYzM0NjM5?= =?UTF-8?B?MWQ3Pg==?= List-Help: List-Id: "9fans" <9fans.9fans.net> List-Post: List-Software: Topicbox v0 List-Subscribe: Precedence: list Reply-To: 9fans <9fans@9fans.net> List-Unsubscribe: , Topicbox-Delivery-ID: 2:9fans:437d30aa-c441-11e9-8a57-d036212d11b0:522be890-2105-11eb-b15e-8d699134e1fa:M4de9844d7316ae1c346391d7:1:gGw_JBxPqAQwXg9AmZEbcrMhyHuewyyd9Z0ksc_3muU Quoth Steve Simon : > was this hard to reproduce? I've seen it sporadically over the last year, and - when looking for it - was able to trigger it deliberately yesterday with minimal effort the first time I looked for it. ...of course, when I was later trying to reproduce it a third time, I wasn't able to trigger it even on the fs running *without* the patch, so. ~50% reproducibility rate so far when I'm actively trying to hit it. I'm fairly sure the root cause is a race condition between some of the periodic threads - this is only triggered when we try to flush a clean block, which isn't a common occurrence - but I wouldn't have put in so much effort to fix this if it wasn't something I semiregularly ran into. for(f in `{walk /sys}) chmod +w $f I think this, combined with the periodic flush routines and tight timing, consistently reproduces it. There's probably a more general way to do so, but without diving even deeper and seeing how we end up trying to flush clean blocks, it's hard to say for sure. fossil is *usually* pretty stable for me these days. My thinkpad often has an uptime of weeks, and usually resets because I'm hacking on the system and need to reboot to test it, not because of fossil. I *have* seen bugs depressingly often, though. Once every month or so, pretty consistently. e.g. building any version of Go newer than 1.7 on my thinkpad crashes fossil with ~50% consistency. The rest of the time, it alternates between sporadic failures due to bugs in the Go compiler, and actually working. Similarly, using kvik's clone tool to move large volumes of data has been a reliable way to crash fossil for me in the past (100% reliability - there was an invocation that would cause the system to die literally every time, but I don't remember exactly which dataset it was, or what level of parallelism was required). ------------------------------------------ 9fans: 9fans Permalink: https://9fans.topicbox.com/groups/9fans/T354fe702e1e9d5e9-M4de98= 44d7316ae1c346391d7 Delivery options: https://9fans.topicbox.com/groups/9fans/subscription