From: Tad Hunt <tad@entrisphere.com>
To: 9fans@cse.psu.edu
Subject: [9fans] bug in powerpc libc powerpc memccpy.s
Date: Thu, 3 Jul 2003 13:56:08 -0700 [thread overview]
Message-ID: <MOBYDICKBYXifWoqFXf000000cd@mobydick.int.entrisphere.com> (raw)
There is only one required change, Line 22 needs to change from
the MOVW to the ADD. As implemented, memccpy() returns the wrong
pointer into the wrong string. The other changes are whitespace
related. Oh yeah, and the Z on the store doesn't really make sense
to me, so I got rid of it. The store with or without the Z results
in the same instruction.
-Tad
diff local/sys/src/libc/power/memccpy.s dist/sys/src/libc/power/memccpy.s
3c3
< MOVW R3, s1+0(FP)
---
> MOVW R3, s1+0(FP)
7d6
<
11d9
<
17c15
< MOVBU R6, 1(R3)
---
> MOVBZU R6, 1(R3)
24c22
< ADD $1, R3
---
> MOVW R4, R3
reply other threads:[~2003-07-03 20:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MOBYDICKBYXifWoqFXf000000cd@mobydick.int.entrisphere.com \
--to=tad@entrisphere.com \
--cc=9fans@cse.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).