9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: Tim Newsham <newsham@lava.net>
To: 9fans@cse.psu.edu
Subject: [9fans] /sys/src/fs/port/auth.c
Date: Tue, 12 Apr 2005 15:22:19 -1000	[thread overview]
Message-ID: <Pine.BSI.4.61.0504121518570.5044@malasada.lava.net> (raw)

Around /sys/src/fs/port/auth.c:312 a ticket request is sent
to the client without first sending the tr.type field to
AuthTreq.  This violates the protocol as documented in
authsrv(6).  I would submit a patch but I dont run my own
kenfs and cant validate the fix.

I'm suprised this is tolerated, doesn't the 9p client check
this field for validity?  The auth server will not honor
the ticket request if it is passed on without first filling
in this field.

Semi-related question: why is the p9sk1 protocol slightly different
in /sys/src/fs (ie. "v.2 p9sk1@...\0", and "OK\0")?

Tim Newsham
http://www.lava.net/~newsham/


             reply	other threads:[~2005-04-13  1:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-13  1:22 Tim Newsham [this message]
2005-04-13  1:27 ` Russ Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.BSI.4.61.0504121518570.5044@malasada.lava.net \
    --to=newsham@lava.net \
    --cc=9fans@cse.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).