From mboxrd@z Thu Jan  1 00:00:00 1970
Date: Tue, 12 Apr 2005 15:22:19 -1000
From: Tim Newsham <newsham@lava.net>
To: 9fans@cse.psu.edu
Message-ID: <Pine.BSI.4.61.0504121518570.5044@malasada.lava.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Subject: [9fans] /sys/src/fs/port/auth.c
Topicbox-Message-UUID: 37094754-ead0-11e9-9d60-3106f5b1d025

Around /sys/src/fs/port/auth.c:312 a ticket request is sent
to the client without first sending the tr.type field to
AuthTreq.  This violates the protocol as documented in
authsrv(6).  I would submit a patch but I dont run my own
kenfs and cant validate the fix.

I'm suprised this is tolerated, doesn't the 9p client check
this field for validity?  The auth server will not honor
the ticket request if it is passed on without first filling
in this field.

Semi-related question: why is the p9sk1 protocol slightly different
in /sys/src/fs (ie. "v.2 p9sk1@...\0", and "OK\0")?

Tim Newsham
http://www.lava.net/~newsham/