From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Viro To: 9fans@cse.psu.edu Subject: Re: [9fans] v9fs release In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Date: Thu, 28 Nov 2002 13:19:49 -0500 Topicbox-Message-UUID: 2a050f5c-eacb-11e9-9e20-41e7f4b1d025 On Thu, 28 Nov 2002, Greg Watson wrote: > ...and we are planning to mount users home directories, etc. using > v9fs. There's an automounter that mounts the filesystems in a private > namespace each time a process is executed on a node. When the process > terminates the filesystems are auto unmounted. Umm... Why the devil was that stuff mixed with 9P support, again? Do one thing and do it well and all such... Frankly, after the look through the source... Folks, it's unmergable. There are 4 or 5 unrelated patches trying to get out of that beast and as it is the combination will be vetoed. And please, please, use the sane coding style. Either one described in Documentation/CodingStyle or the style common in Plan 9 kernel - they are close enough. I can post detailed review either on fsdevel or here tomorrow (probably the former - code and design review of that stuff doesn't look on-topic for 9fans). And no, it won't be pleasant - aside of very sloppy programming in a lot of places, there are outright races aplenty. /me sadly shakes head and ponders adding "Required reading: K&P" into the place where required versions of cc/binutils/etc. are described...