From: Matthew J Jones <elly1@andrew.cmu.edu>
To: 9fans@9fans.net
Subject: [9fans] Race condition in /sys/src/9/pc/trap.c?
Date: Thu, 30 Jul 2009 00:03:04 -0400 [thread overview]
Message-ID: <Pine.LNX.4.64-044.0907292358420.16262@unix10.andrew.cmu.edu> (raw)
My familiarity with the kernel source code is superficial to say the
least, but it seems to me that this code (from /sys/src/9/pc/trap.c)
contains a race condition:
702 if(sp<(USTKTOP-BY2PG) || sp>(USTKTOP-sizeof(Sargs)-BY2WD))
703 validaddr(sp, sizeof(Sargs)+BY2WD, 0);
704
705 up->s = *((Sargs*)(sp+BY2WD));
We verify that the address is correct; is there any reason another thread
in the same address space cannot start running after line 703 completes
and unmap that memory, causing us to access unmapped memory at line 705?
The system call entry is itself an interrupt gate, but line 689 is
spllo(), and we appear to hold no locks at this point.
(Please forgive me if my terminology is not in line: as I said, my
experience is very limited and I am just beginning to explore the source).
-- Elly
next reply other threads:[~2009-07-30 4:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 4:03 Matthew J Jones [this message]
2009-07-30 11:27 ` erik quanstrom
2009-07-30 14:25 ` Elizabeth Jones
2009-07-30 14:37 ` Sape Mullender
2009-07-30 15:01 ` cinap_lenrek
2009-07-30 15:24 ` cinap_lenrek
2009-07-30 15:17 ` cinap_lenrek
2009-07-30 15:54 ` Charles Forsyth
2009-07-31 13:07 ` Charles Forsyth
2009-07-31 13:28 ` Richard Miller
2009-07-31 17:13 ` cinap_lenrek
2009-07-31 18:00 ` erik quanstrom
2009-07-31 18:08 ` Devon H. O'Dell
2009-07-31 18:18 ` erik quanstrom
2009-07-31 18:35 ` Devon H. O'Dell
2009-07-31 21:52 ` cinap_lenrek
2009-07-31 19:31 ` Charles Forsyth
2009-07-31 19:40 ` erik quanstrom
2009-07-31 20:41 ` Charles Forsyth
2009-07-30 15:20 ` erik quanstrom
2009-07-30 14:39 ` erik quanstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64-044.0907292358420.16262@unix10.andrew.cmu.edu \
--to=elly1@andrew.cmu.edu \
--cc=9fans@9fans.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).