Re: [9fans] 9vx.OSX bug: resize on second display causes window to go wrong

[underspecified <underspecified@gmail.com>]

Sorry, I was a bit hasty with the patch. This one should compile properly:

diff -r ca5b26cbe43a src/9vx/osx/screen.c
--- a/src/9vx/osx/screen.c	Tue Jul 01 17:27:41 2008 -0400
+++ b/src/9vx/osx/screen.c	Fri Jul 04 01:31:37 2008 +0900
@@ -513,7 +511,9 @@
 	}else{
 		HideWindow(osx.window);
 		oldwindow = osx.window;
-		BeginFullScreen(&restore, 0, 0, 0, &osx.window, 0, 0);
+		GDHandle device;
+		GetWindowGreatestAreaDevice(osx.window, kWindowTitleBarRgn, &device, NULL);
+		BeginFullScreen(&restore, device, 0, 0, &osx.window, 0, 0);
 		osx.isfullscreen = 1;
 		osx.fullscreentime = msec();
 	}

--underspecified

On Fri, Jul 4, 2008 at 1:25 AM, underspecified <underspecified@gmail.com> wrote:
> Greetings,
>
> Thanks for finding that snippet, andrey :-) I was about to search the
> acme-sac code for it so I could post a patch.
> After looking through the 9vx code, it looks like russ is handling
> memory allocation for the screen a little differently
> than acme-sac (and possibly drawterm).
>
> In acme-sac, I:
>
> * calculate the maximum possible screen size using the function andrey posted
> * allocate a giant block of memory to handle this size once in screeninit()
>
> In 9vx it looks like russ is:
>
> * calculating the new window size on resize event
> * dynamically reallocating the necessary memory for each resize
>
> Perhaps this has something to do with andrey's problems?
>
> --underspecified
>
> P.S. 9vx will only go into fullscreen on the main display.
> The follow fix should work, but I can't test it now, as I am without
> an external monitor.
>
> diff -r ca5b26cbe43a src/9vx/osx/screen.c
> --- a/src/9vx/osx/screen.c      Tue Jul 01 17:27:41 2008 -0400
> +++ b/src/9vx/osx/screen.c      Fri Jul 04 01:20:59 2008 +0900
> @@ -513,7 +511,9 @@
>       }else{
>               HideWindow(osx.window);
>               oldwindow = osx.window;
> -               BeginFullScreen(&restore, 0, 0, 0, &osx.window, 0, 0);
> +               GDHandle device;
> +               GetWindowGreatestAreaDevice(&osx.window,
> kWindowTitleBarRgn, &device, NULL);
> +               BeginFullScreen(&fullScreenRestore, device, 0, 0,
> &osx.window, 0, 0);
>               osx.isfullscreen = 1;
>               osx.fullscreentime = msec();
>
>
> On Fri, Jul 4, 2008 at 1:05 AM, ron minnich <rminnich@gmail.com> wrote:
>> On Thu, Jul 3, 2008 at 8:55 AM, Uriel <uriel99@gmail.com> wrote:
>>> If there was a single codebase shared
>>> across projects none of this would be an issue at all.
>>
>> you are right but it's a hard problem, we're all tight for time, so
>> the only fix is for somebody to step up and do it.
>>
>> But your question, 'wouldn't it be better to have one thing to do all
>> this different stuff', is certainly answered "probably".
>>
>> ron
>>
>>
>