From mboxrd@z Thu Jan  1 00:00:00 1970
From: erik quanstrom <quanstro@quanstro.net>
Date: Wed, 27 Nov 2013 05:15:19 -0500
To: 9fans@9fans.net
Message-ID: <ab83c3e62c9d2c8886f89dc750c460e4@mikro>
In-Reply-To: <4d70224fbe94a5bc6c67b78276a473cb@isd.dp.ua>
References: <4d70224fbe94a5bc6c67b78276a473cb@isd.dp.ua>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Subject: Re: [9fans] u9fs(4) misuses Fcall.afid in its p9any authentication
	module
Topicbox-Message-UUID: 8c36889c-ead8-11e9-9d60-3106f5b1d025

> /sys/src/cmd/unix/u9fs/authp9any.c
> 	authp9any.c.orig:369,375 - /n/sources/patch/u9fs-afid/authp9any.c:369,378
> 	  		fprint(2, "p9anyattach: afid %d state %d\n", rx->afid, sp->state);
> 	  	if (sp->state == Established && strcmp(rx->uname, sp->uname) == 0
> 	  		&& strcmp(rx->aname, sp->aname) == 0)
> 	+ 	{
> 	+ 		rx->uname = sp->t.suid;		/* will be valid until afid is clunked */
> 	  		return nil;
> 	+ 	}
> 	  	return "authentication failed";
> 	  }
>

without commont on correctness, braces go on the
line on which the if condition ends.

- erik