Re: [9fans] libc/strcmp bug?

[arisawa@ar.aichi-u.ac.jp]

Hello,

Viro said:
>On Fri, 9 Aug 2002, Skip Tavakkolian wrote:
>
>> I believe there is a bug in /sys/src/libc/port/strcmp.c, because
it
>> does not check for null pointers getting passed in before
>> dereferencing them.
>
>Not a libc bug.  Making sure that arguments of strcmp() are
non-NULL >is responsibility of caller.

I agree with Viro.
If null pointer is allowed, strcmp() should be something like
bellow:

int
xstrcmp(char *s, char *t)
{
        if(s == nil){
                if(t)
                        return -1;
                return 0;
        }
        if(t)
                return strcmp(s,t);
        return 1;
}

I used this code somewhere because it was useful.

Kenji Arisawa