9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: Richard Miller <9fans@hamnavoe.com>
To: 9fans@9fans.net
Subject: Re: [9fans] USB3 1Gb ethernet card working on 9legacy (rpi 4)
Date: Tue, 2 Aug 2022 09:50:06 +0100	[thread overview]
Message-ID: <cb4e176e3c2ad67575ab1fb4e3d7239c@hamnavoe.com> (raw)
In-Reply-To: <16593713580.F1ef9C5A9.763092@composer.9fans.topicbox.com>

> So bad maxpkt... etherusb check for maxpkt < 512 which is the max for
> bulk transfers in usb2 high speed. Using 1024 instead fixes the problem.

Thanks, the code was correct when written but the world has moved on!
Is your adapter transmitting packets successfully now?

> Should it chek for the speed of the usb device and set the limit accordingly?

Actually the limit on maxpkt in that context wasn't strictly necessary anyway.
Just remove the check.

diff /n/dump/2022/0802/sys/src/9/bcm/etherusb.c /sys/src/9/bcm/etherusb.c
328c328
<       if(maxpkt < 8 || maxpkt > 512)
---
>       if(maxpkt < 8)

------------------------------------------
9fans: 9fans
Permalink: https://9fans.topicbox.com/groups/9fans/T668643d11149fab4-M7a798f1d29caac2cbe00034f
Delivery options: https://9fans.topicbox.com/groups/9fans/subscription

  reply	other threads:[~2022-08-02  8:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-31 17:58 adr
2022-07-31 18:08 ` hiro
2022-07-31 18:09   ` adr
2022-07-31 21:35 ` Richard Miller
2022-08-01  9:16 ` Richard Miller
2022-08-01 16:29   ` adr
2022-08-02  8:50     ` Richard Miller [this message]
2022-08-03  0:34       ` adr
2022-08-03  3:00         ` adr
2022-08-03 10:57           ` Richard Miller
2022-08-03 18:46             ` adr
2022-08-04 10:13               ` Richard Miller
2022-08-04 11:56                 ` ori
2022-08-04 19:34                 ` adr
2022-08-05 12:14                   ` ori
2022-08-01 16:43   ` adr
2022-08-01 17:06     ` adr
2022-08-02  3:45       ` Lucio De Re
2022-08-02  9:07     ` Richard Miller
2022-08-03  0:52       ` adr
2022-08-03  1:08         ` adr
2022-08-03 12:41           ` Richard Miller
2022-08-03 18:47             ` adr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb4e176e3c2ad67575ab1fb4e3d7239c@hamnavoe.com \
    --to=9fans@hamnavoe.com \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).