From: erik quanstrom <quanstro@quanstro.net>
To: 9fans@9fans.net
Subject: Re: [9fans] Kernel crash bug
Date: Sat, 1 Aug 2009 21:38:16 -0400 [thread overview]
Message-ID: <ccf33bfa3bb16eaa82d860ce725abeb4@quanstro.net> (raw)
In-Reply-To: <Pine.LNX.4.64-044.0908011839420.12216@unix10.andrew.cmu.edu>
diff -c /n/dump/2009/0801/sys/src/9/port/sysproc.c sysproc.c
/n/dump/2009/0801/sys/src/9/port/sysproc.c:234,247 - sysproc.c:234,248
ulong magic, text, entry, data, bss;
Tos *tos;
- validaddr(arg[0], 1, 0);
- file = (char*)arg[0];
+ file = nil;
indir = 0;
elem = nil;
if(waserror()){
free(elem);
+ free(file);
nexterror();
}
+ file = validnamedup((char*)arg[0], 1);
for(;;){
tc = namec(file, Aopen, OEXEC, 0);
if(waserror()){
diff -c /n/dump/2009/0801/sys/src/9/port/chan.c chan.c
/n/dump/2009/0801/sys/src/9/port/chan.c:1689,1701 - chan.c:1689,1698
if((ulong)name < KZERO){
validaddr((ulong)name, 1, 0);
if(!dup)
- print("warning: validname called from %lux with user pointer", pc);
+ print("warning: validname called from %#p with user pointer", pc);
p = name;
t = BY2PG-((ulong)p&(BY2PG-1));
- while((ename=vmemchr(p, 0, t)) == nil){
- p += t;
- t = BY2PG;
- }
+ ename = vmemchr(name, 0, 1<<16);
}else
ename = memchr(name, 0, (1<<16));
next prev parent reply other threads:[~2009-08-02 1:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-01 21:01 Elizabeth Jones
2009-08-01 21:37 ` cinap_lenrek
2009-08-01 22:01 ` Charles Forsyth
2009-08-01 22:08 ` Russ Cox
2009-08-01 22:47 ` Elizabeth Jones
2009-08-01 23:09 ` Russ Cox
2009-08-01 23:15 ` cinap_lenrek
2009-08-02 1:38 ` erik quanstrom [this message]
2009-08-02 2:13 ` erik quanstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccf33bfa3bb16eaa82d860ce725abeb4@quanstro.net \
--to=quanstro@quanstro.net \
--cc=9fans@9fans.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).