From mboxrd@z Thu Jan 1 00:00:00 1970 From: erik quanstrom Date: Sun, 10 May 2015 13:51:42 -0700 To: 9fans@9fans.net Message-ID: In-Reply-To: <836e436c5d5dad6e4a07e45ab01ae80b@felloff.net> References: <836e436c5d5dad6e4a07e45ab01ae80b@felloff.net> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Subject: Re: [9fans] fossil+venti performance question Topicbox-Message-UUID: 51042c06-ead9-11e9-9d60-3106f5b1d025 > 2.a) tcpiput() gets a ACK packet for Listening connection, calls tcpincoming(). > 2.b) tcpincoming() looks in limbo, finds lp. and makes new connection. > 3.c) initialize our connections tcb->mss. > > > * the setting of tcb->mss in tcpincoming is not correct, tcp->mss is > > set by SYN, not by ACK, and may not be reset. (see snoopy below.) > > you say we shouldnt initialize tcb->mss in 3.c and not use the mss from the > initial SYN to adjust it. i dont understand why not as i dont see where it > would be initialized otherwise. it appears that was what the initial patch > from david was about to fix which made sense to me. that was the opposite of what i was saying. the issue was i misread tcpincoming(). - erik