From mboxrd@z Thu Jan  1 00:00:00 1970
Message-ID: <d4ce40f4e6116bd069840b25586066c2@quanstro.net>
To: 9fans@9fans.net
From: erik quanstrom <quanstro@quanstro.net>
Date: Sun, 29 Jun 2008 10:18:25 -0400
In-Reply-To: <A14B2B45-67BD-4E40-B056-68EF3CAA687F@mac.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Subject: Re: [9fans] kenc: casting expression to void not ignored
Topicbox-Message-UUID: cb634c30-ead3-11e9-9d60-3106f5b1d025

> Hello. I have a simple push macro for a stack machine interpreter. It
> looks like this:
>
> 	#define push(s) ((void)(((stackptr >= (stack + stacksize)) ?
> growstack() : (void)0), (*stackptr++ = errcheck(s))))
>
> Does this boggle the mind? It's very simple: it checks for stack
> overflow and makes the stack bigger if so, then checks to see if s, a
> double, is NaN or ±Inf, and finally pushes it onto the stack if not
> (errcheck calls longjmp - how I wish I had try).
>
> However, when I use the push macro, I get tons of warnings like this:
>
> 	warning: run.c:170 result of operation not used
>
> Shouldn't the cast to void mean that I don't intend to use the result
> of the operation? Thanks.

no.  USED(x) where x is a variable name means you do not intend to use
the result of the operation. why don't you write push like this instead?

void
push(Whatever *s)
{
	if(stackptr >= stack + stacksize)
		growstack();
	*stackptr++ = errcheck(s)
}

this eliminates two wierd void casts, a ternary operator,
a comma operator and your warning.  i find it
difficult to imagine that a function call would be significant
overhead in this case.

on the certainly wrong assumption that the function call
needs to be avoided, there's no rule that one can't use if
statements in macros:

#define push(s)\
	do {\
		if(stackptr >= stack + stacksize)\
			growstack;\
		*stackptr++ = errcheck(s);\
	} while(0)

but for pete's sake, use a function until you know it's
too slow.

- erik