From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: From: Fco.J.Ballesteros To: 9fans@cse.psu.edu Subject: Re: [9fans] mpg123 In-Reply-To: <200302101453.h1AEr0Z20581@zamenhof.cs.utwente.nl> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="upas-uvifmkfcdiqbbockusvbnpetfy" Date: Mon, 10 Feb 2003 16:05:27 +0100 Topicbox-Message-UUID: 560cbdfc-eacb-11e9-9e20-41e7f4b1d025 This is a multi-part message in MIME format. --upas-uvifmkfcdiqbbockusvbnpetfy Content-Disposition: inline Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit You have to compile madplay and not minimad. Minimad does almost no error recovery at all. --upas-uvifmkfcdiqbbockusvbnpetfy Content-Type: message/rfc822 Content-Disposition: inline Received: from mail.cse.psu.edu ([130.203.4.6]) by aquamar; Mon Feb 10 15:54:23 MET 2003 Received: from psuvax1.cse.psu.edu (psuvax1.cse.psu.edu [130.203.6.6]) by mail.cse.psu.edu (CSE Mail Server) with ESMTP id 1A41519A05; Mon, 10 Feb 2003 09:54:09 -0500 (EST) Delivered-To: 9fans@cse.psu.edu Received: from utrhcs.cs.utwente.nl (utrhcs.cs.utwente.nl [130.89.10.247]) by mail.cse.psu.edu (CSE Mail Server) with ESMTP id 4595B19A05 for <9fans@cse.psu.edu>; Mon, 10 Feb 2003 09:53:05 -0500 (EST) Received: from zeus.cs.utwente.nl (zeus.cs.utwente.nl [130.89.10.12]) by utrhcs.cs.utwente.nl (8.12.5/8.12.5) with ESMTP id h1AEr2Go022876 for <9fans@cse.psu.edu>; Mon, 10 Feb 2003 15:53:02 +0100 (MET) Received: from zamenhof.cs.utwente.nl (zamenhof [130.89.13.77]) by zeus.cs.utwente.nl (8.12.5/8.12.5) with ESMTP id h1AEr07U003360 for <9fans@cse.psu.edu>; Mon, 10 Feb 2003 15:53:00 +0100 (MET) Received: from localhost (belinfan@localhost) by zamenhof.cs.utwente.nl (8.11.6+Sun/8.10.2) with SMTP id h1AEr0Z20581 for <9fans@cse.psu.edu>; Mon, 10 Feb 2003 15:53:00 +0100 (MET) Message-Id: <200302101453.h1AEr0Z20581@zamenhof.cs.utwente.nl> X-Authentication-Warning: zamenhof.cs.utwente.nl: belinfan@localhost didn't use HELO protocol To: 9fans@cse.psu.edu Subject: Re: [9fans] mpg123 In-reply-to: Your message of "Mon, 10 Feb 2003 15:34:04 +0100." <838b9e71b3d2c9e015ed50b2bd73c32c@plan9.escet.urjc.es> References: <838b9e71b3d2c9e015ed50b2bd73c32c@plan9.escet.urjc.es> From: Axel Belinfante X-Organisation: University of Twente, Department of Computer Science, Formal Methods and Tools Group, PO Box 217, NL-7500 AE Enschede, The Netherlands X-Phone: +31 53 4893774 X-Telefax: +31 53 4893247 X-Face: 3YGZY^_!}k]>-k'9$LK?8GXbi?vs=2v*ut,/8z,z!(QNBk_>~:~"MJ_%i`sLLqGN,DGbkT@ N\jhX/jNLTz2hO_R"*RF(%bRvk+M,iU7SvVJtC*\B6Ud<7~`MGMp7rCI6LVp=%k=HE?-UCV?[p\$R? mI\n2/!#3/wZZsa[m7d;PKWiuH6'~ X-Virus-Scanned: by AMaViS-perl11-milter (http://amavis.org/) Sender: 9fans-admin@cse.psu.edu Errors-To: 9fans-admin@cse.psu.edu X-BeenThere: 9fans@cse.psu.edu X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: 9fans@cse.psu.edu List-Id: Fans of the OS Plan 9 from Bell Labs <9fans.cse.psu.edu> List-Archive: Date: Mon, 10 Feb 2003 15:53:00 +0100 > The mad player uses fixed point and is quite optimized. > I think the ported version is in our web page. > It's what I use in the bitsy and works properly there > (needless to say on a pc). I used it, took it from your web page, but I found that there are some mp3's which it doesn't play but which mpg123 does play. (something to do with mp3 headers?) > Because it computes (around line 170 of layer3.c) > 1 - tan(3 * Pi / 4) which is 0 > and then a series of values which involve dividing > by it. I hacked around this in mpg123 by checking for a divisor of 0.0 and replacing it by something small but unequal to zero. I got away with that but Nigels solution (which I did not try) looks nicer. > I would guess that row 9 of the table is not used, > so that putting > if (i == 9) continue; > in the loop will fix it. Axel. --upas-uvifmkfcdiqbbockusvbnpetfy--